Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite with typescript #22

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

rewrite with typescript #22

wants to merge 7 commits into from

Conversation

bingliang-zh
Copy link

  • add tsconfig.json (with strict on)

  • convert all js files to ts

  • remove applyMatrix3 from Vector3

  • BUILD SETTINGS are not set up currectly for now

@dannyrb dannyrb self-requested a review August 9, 2019 03:20
@bingliang-zh bingliang-zh force-pushed the rewrite-in-typescript branch 2 times, most recently from 4031f6f to 562afbf Compare August 14, 2019 06:33
@bingliang-zh bingliang-zh force-pushed the rewrite-in-typescript branch from 562afbf to 96e00d1 Compare August 14, 2019 06:54
@coveralls
Copy link

coveralls commented Aug 14, 2019 •
edited
Loading

Coverage Status

Coverage increased (+9.7%) to 48.839% when pulling f3564e7 on bingliang-zh:rewrite-in-typescript into c893420 on cornerstonejs:master.

@bingliang-zh
Copy link
Author

I think the remaining 8 issues checked by codeclimate are not so urgent to be fixed. Go on finishing other parts.

@bingliang-zh bingliang-zh force-pushed the rewrite-in-typescript branch from 0affc0f to 9da19c2 Compare August 15, 2019 02:46
@bingliang-zh bingliang-zh changed the title WIP: rewrite with typescript rewrite with typescript Aug 15, 2019
@bingliang-zh
Copy link
Author

bingliang-zh commented Aug 15, 2019 •
edited
Loading

There are some dependencies issues need Node 10. Would be nice to see travis-ci's node version being updated.
All npm scripts are checked.

@bingliang-zh bingliang-zh marked this pull request as ready for review August 15, 2019 03:45
@bingliang-zh
Copy link
Author

I need some feedback.

dannyrb
dannyrb reviewed Sep 30, 2019
View reviewed changes
package.json Show resolved Hide resolved
@bingliang-zh
Copy link
Author

Travis CI failed due to this, how can I upgrade that?

error @typescript-eslint/[email protected]: The engine "node" is incompatible with this module. Expected version "^8.10.0 || ^10.13.0 || >=11.10.1". Got "9.11.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyrb dannyrb dannyrb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bingliang-zh @coveralls @dannyrb