Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shake animation and storage functionality #966

Open
wants to merge 5 commits into
base: notes-feature
Choose a base branch
from

Conversation

Destaq
Copy link
Member

@Destaq Destaq commented Nov 21, 2024

Summary

Implemented backend logic and animations for persistent note storage on course cards, tied to uniqueIDs, in addition to fixing some type issues and slimming down the code.

Remaining TODOs:

  • UI fixes (see here and any corresponding feedback from Joana)
  • styling fixes (e.g. pushing down cards, z-index, etc. — itemized in the Slack as well)

Test Plan

  1. Click on the three dots next to a course card
  2. Press Note
  3. Type in a note and press enter
  4. Recognize that a note has now been saved (visually with the mini-dropdown), and note that this is persistent — stays on refresh

Can also try clicking on notes to expand them, clicking outside to hide, clicking outside when the form input is dirty to view the shaking animation, clicking on the note menu item again when already open to also see that there is a shaking animation, etc.

@Destaq Destaq requested a review from a team as a code owner November 21, 2024 02:22
@dti-github-bot
Copy link
Member

dti-github-bot commented Nov 21, 2024

[diff-counting] Significant lines: 175.

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Visit the preview URL for this PR (updated for commit 718dbd7):

https://cornelldti-courseplan-dev--pr966-shake-animation-and-l7lgqd5v.web.app

(expires Sat, 21 Dec 2024 02:26:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants