feat: migration for new cs major requirements #939
Conversation
|
|
|
|
import-brain
changed the title
hiiiiiii thanks for the pr request Eric! |
There was a problem hiding this comment.
Well done Eric, amazing that you are already contributing to CoursePlan like this before freshman even join the team! There are a couple minor issues with your PR — see my comments — but fantastic work. Hopefully you will see your new CS requirements in production on courseplan.io soon 👍 .
| @@ -25,7 +25,7 @@ export type typeOfMigration = 'Modify' | 'Delete' | 'Add'; | |||
|
|
|||
| export type RequirementMigration = { | |||
| entryYear: number /** This migration applies to students with an entryYear equal to or EARLIER this entry year */; | |||
| type: typeOfMigration /** Modify or Delete Migration? This field must already exist in requirements file */; | |||
| type: typeOfMigration /** Modify, Delete, or Add Migration? This field must already exist in requirements file */; | |||
There was a problem hiding this comment.
Good catch here with the enum update. Honestly maybe we should just get rid of this since duplication is evil and TypeScript serves the purpose of that part of the comment. But this is a commenting style nitpick that was already here before you, just sharing here for reference for our TPM.
Hi Simon, thank you for your in-depth code review! I just added a commit addressing your review comments :). |
maintain consistent string styling with rest of codebase
|
Thank you for the speedy fixes! |
|
@import-brain feel free to merge this into main! Might need to push another commit to the check to run though, or speak to @nidhi-mylavarapu about what's going on here. |
|
Summary
Computer Science majors who enter Cornell in Fall 2024 have different requirements compared to those who entered Cornell before that: CS 3700 or CS 3780 is now a required course, there are only two required CS electives, and there is no Probability requirement.
This PR implements migrations in the CS major file to reflect these differences for future CS majors who entered Cornell in Fall 2024.