Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added college scholar major #899

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

added college scholar major #899

wants to merge 1 commit into from

Conversation

ilyssayan
Copy link
Collaborator

Summary

This pull request is the first step towards implementing feature Foo

  • implemented X
  • fixed Y

Remaining TODOs:

  • resolve bug 1
  • implement Z

Depends on #{number of PR}

Test Plan

Notes

Blockers

  • A newly discovered dependency that hasn’t been addressed

Breaking Changes

  • Database schema change (anything that changes Firestore collection structure)
  • Other change that could cause problems (Detailed in notes)

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2024

CLA assistant check
All committers have signed the CLA.

@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 49.

Copy link
Contributor

Visit the preview URL for this PR (updated for commit e17c7f7):

https://cornelldti-courseplan-dev--pr899-college-scholar-majo-991u9z1w.web.app

(expires Fri, 12 Apr 2024 22:03:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

@plumshum
Copy link
Contributor

On your remote repository, have you have ran this line in terminal
npm run req-gen then run npm run serve
This updates the graph for the courses and requirements, so you'll see changes in like the decorated requirements json file so you can see changes on the local courseplan website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants