Implementing Frontend Changes for Recomendations #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 194. |
|
Visit the preview URL for this PR (updated for commit 735b9cd): https://cornelldti-courseplan-dev--pr873-pablo-recomendations-n6iskcqo.web.app (expires Sat, 30 Dec 2023 16:36:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
andxu282
requested changes
Nov 28, 2023
andxu282
reviewed
Nov 28, 2023
| getCoursesTooltipText() { | ||
| return `<div class="introjs-tooltipTop"><div class="introjs-customTitle">These are your Courses</div><div class="introjs-customProgress">2/4</div> | ||
| </div><div class = "introjs-bodytext">Drag and drop courses into your schedule! Click on them to learn more information like their descriptions.</div>`; | ||
| }, | ||
| /** | ||
| * @brief Modify this.state.showAllCourses to show all courses based on showAllCourses object |
There was a problem hiding this comment.
I like these documentations
zachary-kent
requested changes
Dec 1, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change is the second step to implementing recommendations. #866 implemented changes for storing popular courses for requirements. This PR implements the frontend for displaying course recommendations. The next step is to create calls to firebase to retrieve course recommendations to population.
TODO
Test Plan
Given a requirement, use the new frontend to make sure that all courses are present if we are able to query.