Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jc2755/profile page layout #233

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Jc2755/profile page layout #233

wants to merge 2 commits into from

Conversation

Jcheng777
Copy link

@Jcheng777 Jcheng777 commented Nov 15, 2024

Summary

This pull request is the first step towards implementing the profile page overflow bug.

  • implemented SingleChildScrollView for smaller screens to prevent overflow
  • positioned settings button and profile picture higher up on the screen

Remaining TODOs:

  • Testing on smaller phone screens

Depends on #{number of PR}

Test Plan

  • Tested on iPhone 11, 12, 14, 15, 15 pro

…e numbers

- Adjusted progress bar width to dynamically scale based on the number of digits in total points, achievements, etc., providing better visual alignment.
- Implemented formatting to shorten large numbers (e.g., 1500 becomes 1.5K) for improved readability.
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 97.

@Jcheng777 Jcheng777 changed the title Jc2755/profile page Jc2755/profile page layout Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants