-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update journeys and challenges search bar #232
base: master
Are you sure you want to change the base?
Conversation
[diff-counting] Significant lines: 115. |
Nice job on this fix! Make sure to remove the print debug statements, this should be done before you ever make a PR. Also for better readability, try and revisit some of the variable names, moving away from "event.examplefield" to ensure it's clear which entity the difficulty, name, and other fields refer to (see my comment in the journey code for reference). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a specific PR regarding addressing both cleaning up challenges and journeys, I would have a separate util function that can handle both the matching/searching feature in the journeys and challenges page. This can be done in another PR though.
Summary
This pull request implements additional and fixes current search features in both Journeys and Challenges.
Remaining TODOs: