Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update journeys and challenges search bar #232

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

shah-esha
Copy link
Collaborator

@shah-esha shah-esha commented Nov 11, 2024

Summary

This pull request implements additional and fixes current search features in both Journeys and Challenges.

  • implemented searching by difficulty
  • simplified code

Remaining TODOs:

  • update documentation for both Journeys and Challenges
  • test through simulation
  • testing outside of just simulating the app locally

@dti-github-bot
Copy link
Member

dti-github-bot commented Nov 11, 2024

[diff-counting] Significant lines: 115.

@3TTemi
Copy link
Contributor

3TTemi commented Nov 17, 2024

Nice job on this fix! Make sure to remove the print debug statements, this should be done before you ever make a PR. Also for better readability, try and revisit some of the variable names, moving away from "event.examplefield" to ensure it's clear which entity the difficulty, name, and other fields refer to (see my comment in the journey code for reference).

Copy link
Contributor

@BrianLa0616 BrianLa0616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a specific PR regarding addressing both cleaning up challenges and journeys, I would have a separate util function that can handle both the matching/searching feature in the journeys and challenges page. This can be done in another PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants