Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Journeys Search Bar Bug #230

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Journeys Search Bar Bug #230

wants to merge 3 commits into from

Conversation

shah-esha
Copy link
Collaborator

@shah-esha shah-esha commented Oct 28, 2024 •
edited
Loading

Fix Journeys Search Bar Bug

This pull request is to fix the Journeys search bar bug, where no results would show for any searches other than "e".

Remaining TODOs:

  • test changes on default journeys

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 28, 2024 •
edited
Loading

[diff-counting] Significant lines: 28.

BrianLa0616
BrianLa0616 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@BrianLa0616 BrianLa0616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

We might want to look into having an EventsPage that JourneysPage and ChallengesPage both extends as there is a lot of commonalities between these two functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianLa0616 BrianLa0616 BrianLa0616 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shah-esha @CLAassistant @dti-github-bot @BrianLa0616