Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove embedded certificate in openresty image #297

Merged
merged 3 commits into from
Oct 29, 2024
Merged

chore: remove embedded certificate in openresty image #297

merged 3 commits into from
Oct 29, 2024

Conversation

fzipi
Copy link
Member

@fzipi fzipi commented Oct 27, 2024

what

  • remove test certificate stored in the image and generate one at boot

why

  • prevent users from use a well known key/certificate

@fzipi fzipi requested a review from theseion October 27, 2024 20:36
theseion
theseion previously requested changes Oct 28, 2024
View reviewed changes
openresty/Dockerfile-alpine Show resolved Hide resolved
@fzipi
fix: remove openssl.conf file
40af25e 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi requested a review from theseion October 28, 2024 18:40
@fzipi fzipi dismissed theseion’s stale review October 28, 2024 20:20

Cleaned up file.

@fzipi fzipi merged commit ac69620 into coreruleset:main Oct 29, 2024
6 checks passed
@fzipi fzipi deleted the remove-key-openresty branch October 29, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseion theseion theseion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzipi @theseion