Properly prune previous containers when rebasing #4138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
cgwalters
force-pushed
the
container-purge-rebase
branch
from
edabe75 to
a54b4e9
Compare
|
Rebased this one on #4140 |
If a container image reference is pruned, we must not error out when computing the status. The deployment roots will hold a strong reference to the deployed commit, so query via the commit digest to find metadata about the pulled container image.
cgwalters
force-pushed
the
container-purge-rebase
branch
from
a54b4e9 to
17bc89c
Compare
When using `rpm-ostree rebase` on ostree branch names, by default we prune the previous branch/ref to avoid leaking space (i.e. requiring the user/admin to manually prune it). We do have the `--skip-purge` option to suppress this behavior. When we added the container bits, we ignored this at the time. But we really need to do this by default, for the same reasons around avoiding space leakage.
cgwalters
force-pushed
the
container-purge-rebase
branch
from
17bc89c to
904e111
Compare
|
OK, this one is rebased 🏄 and should be good to go! |
lucab
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends:
daemon: Query container image commit
If a container image reference is pruned, we must not error
out when computing the status. The deployment roots will hold
a strong reference to the deployed commit, so query via the commit
digest to find metadata about the pulled container image.
When rebasing, prune previous container by default
When using
rpm-ostree rebaseon ostree branch names, bydefault we prune the previous branch/ref to avoid leaking
space (i.e. requiring the user/admin to manually prune it).
We do have the
--skip-purgeoption to suppress this behavior.When we added the container bits, we ignored this at the time.
But we really need to do this by default, for the same reasons
around avoiding space leakage.
Closes: #4136