Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpriv/core: workaround libdnf vars path lookup #3652

Merged
merged 2 commits into from
May 3, 2022

Conversation

lucab
Copy link
Contributor

@lucab lucab commented May 3, 2022

libdnf internally adds an install_root prefix to vars directories,
resulting in misplaced lookups to <install_root>/etc/dnf/vars.
As a workaround, this inserts a relevant amount of /.. in order to cancel
out the path prefix.

Ref: #3241

@lucab
Copy link
Contributor Author

lucab commented May 3, 2022

/hold

lucab added 2 commits May 3, 2022 14:41
libdnf internally adds an `install_root` prefix to vars directories,
resulting in misplaced lookups to `<install_root>/etc/dnf/vars`.
As a workaround, this inserts a relevant amount of `/..` in order to cancel
out the path prefix.
@lucab lucab force-pushed the ups/dnf-vars-dir-workaround branch from 1778448 to 6d6b90e Compare May 3, 2022 14:42
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this as is but would have preferred carrying a libdnf patch.

@cgwalters cgwalters merged commit da4aa26 into coreos:main May 3, 2022
@jlebon
Copy link
Member

jlebon commented May 3, 2022

@lucab, did you mean to have this merged yet? I see a hold label and your comment here mentioning it doesn't fully resolve the issue.

@lucab
Copy link
Contributor Author

lucab commented May 4, 2022

Yes, this was on-hold as I still had to manually check that the additional commit fixed both install and refresh-md flows.
The good news is that both are working fine now, so we can even close #3241.

I'd rather not carry a fork of libdnf given that we already have troubles handling plain submodule updates, and that there was not reaction upstream yet.

@lucab
Copy link
Contributor Author

lucab commented May 4, 2022

/hold cancel

@lucab lucab deleted the ups/dnf-vars-dir-workaround branch May 4, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants