Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-bot: add experimental branch and support branch-level skip files #171

Merged
merged 2 commits into from
May 18, 2023

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented May 3, 2023

With the new experimental stream, we want to have more freedom in what
files go in there without having to also pollute testing-devel.

Add support for a .coreos.skip-files file which will tell config-bot
to not clobber a specific set of files on that ref. This augments the
global-level skip-files list.

Related: coreos/fedora-coreos-tracker#1446

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane to me

@jlebon
Copy link
Member Author

jlebon commented May 3, 2023

OK, let's hold this until we have the experimental branch up so it doesn't try to sync to a missing branch. Want to add .coreos.skip-files to your commit and create the branch? (And also the prod flip.)

With the new experimental stream, we want to have more freedom in what
files go in there without having to also pollute `testing-devel`.

Add support for a `.coreos.skip-files` file which will tell config-bot
to not clobber a specific set of files on that ref. This augments the
global-level `skip-files` list.

Related: coreos/fedora-coreos-tracker#1446
@jlebon jlebon force-pushed the pr/configbot-experimental branch from 6c3114c to 903e815 Compare May 3, 2023 17:25
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon merged commit e820eb9 into coreos:main May 18, 2023
@jlebon jlebon deleted the pr/configbot-experimental branch May 18, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants