-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnf5: use new syntax #3238
dnf5: use new syntax #3238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested, but after a little bit of a research this /lgtm
@@ -5,7 +5,7 @@ set -euo pipefail | |||
|
|||
dnf -y install dnf-plugins-core | |||
# We want to avoid a 7 day cycle for e.g. new ostree etc. | |||
dnf config-manager --set-enabled updates-testing | |||
dnf config-manager setopt updates-testing.enabled=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I first thought it should be --setopt
. According to docs I was wrong, so this lgtm.
@@ -35,7 +35,7 @@ rm -rf "${tmpd:?}"/* | |||
echo "Installing build dependencies from canonical spec files" | |||
specs=$(grep -v '^#' "${dn}"/buildroot-specs.txt) | |||
(cd "${tmpd}" && echo "${specs}" | xargs curl -L --remote-name-all) | |||
(cd "${tmpd}" && find . -type f -print0 | xargs -0 dnf -y builddep --spec) | |||
(cd "${tmpd}" && find . -type f -print0 | xargs -0 dnf -y builddep) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fedora 41 uses dnf5, which doesn't support
--set-enabled
and--spec
switches: