Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnf5: use new syntax #3238

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

nikita-dubrovskii
Copy link
Contributor

@nikita-dubrovskii nikita-dubrovskii commented Oct 30, 2024

Fedora 41 uses dnf5, which doesn't support --set-enabled and --spec switches:

Unknown argument "--set-enabled" for command "config-manager"
Unknown argument "--spec" for command "builddep".

@nikita-dubrovskii nikita-dubrovskii changed the title dnf5: use 'setopt' to enable 'updates-testing' repo dnf5: use new syntax Oct 30, 2024
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe enabled auto-merge (rebase) October 30, 2024 11:34
Copy link
Member

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but after a little bit of a research this /lgtm

@@ -5,7 +5,7 @@ set -euo pipefail

dnf -y install dnf-plugins-core
# We want to avoid a 7 day cycle for e.g. new ostree etc.
dnf config-manager --set-enabled updates-testing
dnf config-manager setopt updates-testing.enabled=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I first thought it should be --setopt. According to docs I was wrong, so this lgtm.

@@ -35,7 +35,7 @@ rm -rf "${tmpd:?}"/*
echo "Installing build dependencies from canonical spec files"
specs=$(grep -v '^#' "${dn}"/buildroot-specs.txt)
(cd "${tmpd}" && echo "${specs}" | xargs curl -L --remote-name-all)
(cd "${tmpd}" && find . -type f -print0 | xargs -0 dnf -y builddep --spec)
(cd "${tmpd}" && find . -type f -print0 | xargs -0 dnf -y builddep)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I don't know too much about this, but based on @jlebon commit it makes sense.

@dustymabe dustymabe merged commit 7ef7e40 into coreos:testing-devel Oct 30, 2024
3 checks passed
@nikita-dubrovskii nikita-dubrovskii deleted the dnf5_fix branch October 30, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants