Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/cosa/run: Remove unneeded rootfs in UEFI SB GRUB config #3810

Merged
merged 1 commit into from
May 23, 2024

Conversation

travier
Copy link
Member

@travier travier commented May 23, 2024

See: #3806 (comment)
Fixes: 0b53c4e docs/cosa/run: Add PXE with Shim and UEFI Secure Boot example

See: coreos#3806 (comment)
Fixes: 0b53c4e docs/cosa/run: Add PXE with Shim and UEFI Secure Boot example
Copy link
Member

@HuijingHei HuijingHei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@travier
Copy link
Member Author

travier commented May 23, 2024

/override ci/prow/rhcos

Copy link

openshift-ci bot commented May 23, 2024

@travier: Overrode contexts on behalf of travier: ci/prow/rhcos

In response to this:

/override ci/prow/rhcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jlebon jlebon merged commit 2b7db04 into coreos:main May 23, 2024
4 checks passed
@travier travier deleted the docs-pxe-uefi-fixup branch May 24, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants