Revert "create_disk: add version field to aleph file" #3686
+1
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c2d37f4. We found an issue with this and need to revert it for now: coreos/bootupd#585 (comment)
cgwalters
approved these changes
Dec 18, 2023
This was referenced Dec 18, 2023
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Jun 27, 2024
This causes bootupctl to fails while parsing the file. The extra field was introduced in coreos/coreos-assembler@c2d37f4 then quickly reverted in coreos/coreos-assembler#3686 Still, a couple of builds (39.20231204.1.0 and 39.20231204.2.1) went out with the change. Fixing this will allow bootupctl to function properly on nodes deployed with this version. This jq filter is idempotent so it's safe to run on all nodes. This should be removed after the next barrier release. Fixes coreos/fedora-coreos-tracker#1724
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Jun 27, 2024
This causes bootupctl to fails while parsing the file. The extra field was introduced in coreos/coreos-assembler@c2d37f4 then quickly reverted in coreos/coreos-assembler#3686 Still, a couple of builds (39.20231204.1.0 and 39.20231204.2.1) went out with the change. Fixing this will allow bootupctl to function properly on nodes deployed with this version. This jq filter is idempotent so it's safe to run on all nodes. This should be removed after the next barrier release. Fixes coreos/fedora-coreos-tracker#1724
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Jun 27, 2024
This causes bootupctl to fails while parsing the file. The extra field was introduced in coreos/coreos-assembler@c2d37f4 then quickly reverted in coreos/coreos-assembler#3686 Still, a couple of builds (39.20231204.1.0 and 39.20231204.2.1) went out with the change. Fixing this will allow bootupctl to function properly on nodes deployed with this version. This jq filter is idempotent so it's safe to run on all nodes. This should be removed after the next barrier release. Fixes coreos/fedora-coreos-tracker#1724
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Jun 27, 2024
This causes bootupctl to fails while parsing the file. The extra field was introduced in coreos/coreos-assembler@c2d37f4 then quickly reverted in coreos/coreos-assembler#3686 Still, a couple of builds (39.20231204.1.0 and 39.20231204.2.1) went out with the change. Fixing this will allow bootupctl to function properly on nodes deployed with this version. This jq filter is idempotent so it's safe to run on all nodes. This should be removed after the next barrier release. Fixes coreos/fedora-coreos-tracker#1724
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Jun 27, 2024
This causes bootupctl to fails while parsing the file. The extra field was introduced in coreos/coreos-assembler@c2d37f4 then quickly reverted in coreos/coreos-assembler#3686 Still, a couple of builds (39.20231204.1.0 and 39.20231204.2.1) went out with the change. Fixing this will allow bootupctl to function properly on nodes deployed with this version. This jq filter is idempotent so it's safe to run on all nodes. This should be removed after the next barrier release. Fixes coreos/fedora-coreos-tracker#1724
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Jun 27, 2024
This causes bootupctl to fails while parsing the file. The extra field was introduced in coreos/coreos-assembler@c2d37f4 then quickly reverted in coreos/coreos-assembler#3686 Still, a couple of builds (39.20231204.1.0 and 39.20231204.2.1) went out with the change. Fixing this will allow bootupctl to function properly on nodes deployed with this version. This jq filter is idempotent so it's safe to run on all nodes. This should be removed after the next barrier release. Fixes coreos/fedora-coreos-tracker#1724
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Jun 27, 2024
This causes bootupctl to fails while parsing the file. The extra field was introduced in coreos/coreos-assembler@c2d37f4 then quickly reverted in coreos/coreos-assembler#3686 Still, a couple of builds (39.20231204.1.0 and 39.20231204.2.1) went out with the change. Fixing this will allow bootupctl to function properly on nodes deployed with this version. This jq filter is idempotent so it's safe to run on all nodes. This should be removed after the next barrier release. Fixes coreos/fedora-coreos-tracker#1724
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Jun 27, 2024
This causes bootupctl to fails while parsing the file. The extra field was introduced in coreos/coreos-assembler@c2d37f4 then quickly reverted in coreos/coreos-assembler#3686 Still, a couple of builds (39.20231204.1.0 and 39.20231204.2.1) went out with the change. Fixing this will allow bootupctl to function properly on nodes deployed with this version. This jq filter is idempotent so it's safe to run on all nodes. This should be removed after the next barrier release. Fixes coreos/fedora-coreos-tracker#1724
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Jun 27, 2024
This causes bootupctl to fails while parsing the file. The extra field was introduced in coreos/coreos-assembler@c2d37f4 then quickly reverted in coreos/coreos-assembler#3686 Still, a couple of builds (39.20231204.1.0 and 39.20231204.2.1) went out with the change. Fixing this will allow bootupctl to function properly on nodes deployed with this version. This jq filter is idempotent so it's safe to run on all nodes. This should be removed after the next barrier release. Fixes coreos/fedora-coreos-tracker#1724
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Jun 27, 2024
This causes bootupctl to fails while parsing the file. The extra field was introduced in coreos/coreos-assembler@c2d37f4 then quickly reverted in coreos/coreos-assembler#3686 Still, a couple of builds (39.20231204.1.0 and 39.20231204.2.1) went out with the change. Fixing this will allow bootupctl to function properly on nodes deployed with this version. This jq filter is idempotent so it's safe to run on all nodes. This should be removed after the next barrier release. Fixes coreos/fedora-coreos-tracker#1724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c2d37f4.
We found an issue with this and need to revert it for now: coreos/bootupd#585 (comment)