Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Config wirirng in flow handler #94

Merged
merged 14 commits into from
Dec 26, 2023
Merged

Project Config wirirng in flow handler #94

merged 14 commits into from
Dec 26, 2023

Conversation

Aby-JS
Copy link
Contributor

@Aby-JS Aby-JS commented Dec 20, 2023

This pull request updates the flowHandlerState class to allow updating the FlowOptions using the project config. This will enable more flexibility in configuring the authentication flows for the project.

@Aby-JS Aby-JS changed the title Update flowHandlerState to allow updating FlowOptions using project config Project Config wirirng in flow handler Dec 21, 2023
@Aby-JS Aby-JS self-assigned this Dec 21, 2023
@Aby-JS Aby-JS added bug Something isn't working enhancement New feature or request labels Dec 21, 2023
This was linked to issues Dec 21, 2023
Wire @corbado/react: wire with developer panel #75
Closed
Issues in flows #95
Closed
incorbador
incorbador requested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@incorbador incorbador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few structural points for flowHandler. I tried to describe them and my ideas to them as good as possible. Let's have a Slack call if they are unclear (I will be on lunch for the next hour, but afterwards I am available).

packages/shared-ui/src/flowHandler/flowHandlerState.ts Outdated Show resolved Hide resolved
packages/shared-ui/src/flowHandler/flowHandler.ts Outdated Show resolved Hide resolved
packages/shared-ui/src/flowHandler/flowHandler.ts Outdated Show resolved Hide resolved
packages/shared-ui/src/flowHandler/flows/index.ts Outdated Show resolved Hide resolved
packages/shared-ui/src/flowHandler/flows/singup/utils.ts Outdated Show resolved Hide resolved
@Aby-JS
Copy link
Contributor Author

Aby-JS commented Dec 21, 2023

@incorbador I have removed some unnecessary variables from flowHandler class like:

  • i18next - since we can directly use at inside flowHandler.init method
  • #currentFlow
  • #flowName - we now get it from the new flowHandlerConfig class

@incorbador
Copy link
Contributor

Changing back to SignUp Flow doesn't work anymore:
image

incorbador
incorbador reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@incorbador incorbador left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the two comments above
One more thing: I have added flowOptions for our two projects in our Database (so the projectConfig now returns false for passkeyAppend and retryPasskeyOnError). I am still seeing the passkey Append screen though. Can you check that again pls?

@incorbador incorbador merged commit 3ef52ec into main Dec 26, 2023
1 check passed
@incorbador incorbador deleted the modify_flow_handler_with_project_config branch December 26, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@incorbador incorbador incorbador approved these changes

Assignees

@Aby-JS Aby-JS

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues in flows Wire @corbado/react: wire with developer panel
2 participants
@Aby-JS @incorbador