-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passkey list for react package #89
Conversation
When I try to create a passkey on a device where I already have one, I get an error in the networking console (this is also expected, our backend does not allow for having multiple passkeys on the same device). We should catch the error and show it to the user (maybe as a red string below the "Create Passkey" button. |
@incorbador I have made all the requested changes and have added translations as well. I think we should handler error in the error handling PR since it would require changes in the errors.ts file and I want to avoid conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above. Regarding the older comments:
- for error handling I agree, let's have a small follow up ticket for that and work on it after we merged the error handling PR
- for "Passkeys" headline: I asked Vincent, we don't have a strong opinion about it so let's not include it (so no TODO for you here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last remaining comment is only about missing translations. Did you already find a fix for the lerna run build:dev problem? After that we can merge this PR.
Notes to review this PR
CorbadoProvider
which takes input of all the theming params and provide custom theming and translations.