Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling for react #86

Merged
merged 14 commits into from
Dec 20, 2023
Merged

Error handling for react #86

merged 14 commits into from
Dec 20, 2023

Conversation

Aby-JS
Copy link
Contributor

@Aby-JS Aby-JS commented Dec 15, 2023

New Errors that have been catered:

authMethods: {
   "type": "validation_error",
   "validation": [
       {
           "field": "username",
           "message": "user doesn't exist"
       }
   ]
}

passkeyLoginStart: {
   "details": "user doesn't exist",
   "type": "not_found"
}

passkeyRegisterStart: {
   "type": "validation_error",
   "validation": [
       {
           "field": "username",
           "message": "Invalid email address"
       }
   ]
}

signupEmailOtpStart: {
 "type": "validation_error",
 "validation": [
   {
     "field": "username",
     "message": "Invalid / unreachable email address"
   }
 ]
}

New Cases that have been handled:

  • If the user tries to login with an email address which is not registered he is shown a "User doesn't exist" error as email input field error.
  • If the user tries to signup with an email for which we recieve invalid/unreachable email address issue from BE we navigate him to the first screen so that he can correct his input and also shown him the error "Invalid / unreachable email address"" as email input field error.

@Aby-JS Aby-JS added the enhancement New feature or request label Dec 15, 2023
@Aby-JS Aby-JS requested a review from incorbador December 15, 2023 18:41
@Aby-JS Aby-JS self-assigned this Dec 15, 2023
@Aby-JS Aby-JS linked an issue Dec 15, 2023 that may be closed by this pull request
6 tasks
Aby-JS and others added 3 commits December 15, 2023 23:49
* State machine for signup flows

* Update login flows

* Removed unused code, synced translations

* Added missing fields to NonRecoverabelError page

* Removed console.logs

* Temporarily deactivate the react-sdk-example

* PR feedback: Formatting, translations for generic error page, general feedback

* Fix hardcoded isDevMode in example

* Fixed react-sdk-example

* PR feedback: error translation structure

---------

Co-authored-by: Incorbador <[email protected]>
@incorbador
Copy link
Contributor

FYI: I will resolve the conflicts here now

@incorbador incorbador merged commit c936c7d into main Dec 20, 2023
1 check passed
@incorbador incorbador deleted the error_handling_for_react branch December 20, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage error handling in react package
2 participants