lang: Require IdlCreateAccounts instruction authority to be the program authority
#3423
+23
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
acheroncrypto
added
lang
breaking
idl
acheroncrypto
commented
Dec 11, 2024
| | bench | 1,041,928 | 🔴 **+250,920 (31.72%)** | | ||
| | bench | 1,106,136 | 🔴 **+315,128 (39.84%)** | |
There was a problem hiding this comment.
It's crazy that this simple change adds ~60 KB to the program binary. I guess we could optimize it by not using the existing types such as ProgramData (which imports bincode) and interpreting the account data ourselves, but given we're planning to get rid of these instructions, it's probably fine to keep it as is and not complicate things further.
There was a problem hiding this comment.
Cool to see that you're tracking this. 60kb does sound way too much, but I agree with you here
|
looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As mentioned in #444 (comment),
IdlCreateAccountsinstruction is permissionless, meaning anyone can claim the IDL authority of a program if it hasn't yet been claimed:anchor/lang/syn/src/codegen/program/idl.rs
Lines 39 to 41 in be3ab99
Summary of changes
Require
fromaccount ofIdlCreateAccountsto be the program authority.Note: This only changes the initial IDL creation instruction authority, meaning any existing IDL authority won't be affected by this change. Ideally, the IDL authority and the program deploy authority should be the same, but given that could break existing programs, it makes more sense to only let the IDL account be initialized by the program deploy authority.
Resolves #444