Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using token metadata client sdk #2632

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

febo
Copy link
Contributor

@febo febo commented Sep 20, 2023

This PR switches the Token Metadata crate to use the Rust client SDK instead of the program crate.

@vercel
Copy link

vercel bot commented Sep 20, 2023

@febo is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@febo febo marked this pull request as ready for review September 23, 2023 13:27
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks good to me overall but we don't have tests for these so might be missing something given the changes. Any chance you've tested these changes?

This also looks like a breaking change, would be great if you could you add an entry to the CHANGELOG.

spl/src/metadata.rs Show resolved Hide resolved
@acheroncrypto acheroncrypto added the dependencies Pull requests that update a dependency file label Sep 23, 2023
@febo
Copy link
Contributor Author

febo commented Sep 25, 2023

Added an entry on the CHANGELOG. I have not tested the changes on the anchor types, as I was relying on the existing ones.

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@acheroncrypto acheroncrypto merged commit 99b75a9 into coral-xyz:master Sep 25, 2023
45 checks passed
@febo febo deleted the febo/metadata-client-sdk branch September 25, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file spl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants