Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import spaCy languages dynamically in XTTS Tokenizer.py #3615

Closed
wants to merge 18 commits into from

Conversation

davidmartinrius
Copy link

Hi!

How are you doing?

This pull request import the spacy language class dynamically with a English fallback when import error in TTS/tts/layers/xtts/tokenizer.py

Thailandese and Vietnamese need 2 extra packages: pythainlp and pyvi

So I added both in the requirements.txt

Korean is the only language that needs some extra packages that needs to be installed manually, by now is the only language that cannot be imported.

I created a function get_all_spacy_langs to verify that all the imports works properly. This is only for testing purposes. If something were wrong in get_spacy_lang there is always a spacy English language fallback.

Thank you!

David Martin Rius

@CLAassistant
Copy link

CLAassistant commented Feb 28, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ Subuday
✅ kikkia
✅ davidmartinrius
❌ defaultdeveloperuser
You have signed the CLA already but the status is still pending? Let us recheck it.

@davidmartinrius davidmartinrius changed the title Import spicy languages dynamically in XTTS Tokenizer.py Import spaCy languages dynamically in XTTS Tokenizer.py Feb 28, 2024
@davidmartinrius
Copy link
Author

davidmartinrius commented Feb 29, 2024

It seems that a validation got stuck: zoo-tests-2 / test (3.10, false)

Please could you unlock it? If there is something I did wrong, please let me know. With the current logs I don't think I can do much.

Also I already signed the CLA but it is still pending.

image

Copy link

stale bot commented Apr 16, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels.

@stale stale bot added the wontfix This will not be worked on but feel free to help. label Apr 16, 2024
@stale stale bot closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on but feel free to help.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants