fix: fairseq unbound variable 'dataset' #3502
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error on using
fairseq
model. Variables likedataset
andmodel
aren't defined.So, this is the bug a user faced recently while using the model
fairseq
, as you can see the user encountered the error: unbound variable 'dataset' in the filemanage.py
in the method_set_model_item
, on inspecting the code, I found that infact, in the condition when fairseq was in 'model_name' there was no declaration of variabledataset
as well as the variablemodel
, so I just added them in the first if condition and it solved the issue. I tested it and it worked like charm.Code:
Error:
fixes: #3142 #3361 #3501
Since this is my first PR, It would be really nice if it would get merged, or if there's anything else I can help with please let me know.
ThankYou.