Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove apparently no-op check_skip steps #3129

Closed
wants to merge 1 commit into from

Conversation

akx
Copy link
Contributor

@akx akx commented Oct 31, 2023

There is nothing in the repo that would refer to them.

They were added in d43a46c by @erogol and probably just copy-pasted onwards from there.

@erogol
Copy link
Member

erogol commented Nov 8, 2023

No, it is on purpose when we need to skip CI for certain updates. But I don't get what you mean by

There is nothing in the repo that would refer to them. Can you expand?

@akx
Copy link
Contributor Author

akx commented Nov 8, 2023

No, it is on purpose when we need to skip CI for certain updates. But I don't get what you mean by

There is nothing in the repo that would refer to them. Can you expand?

Well, as far as I can tell these are just steps that print out the commit message if it doesn't contain [ci skip]?

After all, [ci skip] and friends are natively implemented by GitHub Actions.

@akx
Copy link
Contributor Author

akx commented Dec 4, 2023

ping @erogol, in case you missed my reply above :)

@erogol
Copy link
Member

erogol commented Dec 7, 2023

No, it is on purpose when we need to skip CI for certain updates. But I don't get what you mean by
There is nothing in the repo that would refer to them. Can you expand?

Well, as far as I can tell these are just steps that print out the commit message if it doesn't contain [ci skip]?

After all, [ci skip] and friends are natively implemented by GitHub Actions.

meaning even if we merge this PR [ci skip] is still there natively?

@akx
Copy link
Contributor Author

akx commented Dec 8, 2023

meaning even if we merge this PR [ci skip] is still there natively?

So it would seem.

There is nothing in the repo that would refer to them
@akx
Copy link
Contributor Author

akx commented Dec 13, 2023

Rebased post #3405.

@erogol Could this get merged?

Copy link

stale bot commented Jan 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels.

@stale stale bot added the wontfix This will not be worked on but feel free to help. label Jan 12, 2024
@stale stale bot closed this Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on but feel free to help.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants