Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with new device API #2876

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Update README with new device API #2876

merged 5 commits into from
Aug 28, 2023

Conversation

jaketae
Copy link
Contributor

@jaketae jaketae commented Aug 14, 2023

Context

In #2855, we added a new .to(device) API for the TTS class, allowing users to freely choose the accelerator backend of their choice. We need to update the README with this information.

Solution

Remove examples that use the gpu flag and use to(device) instead.


# List available 🐸TTS models and choose the first one
model_name = TTS.list_models()[0]
model_name = TTS().list_models()[0]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code snippet no longer works because list_models is no longer a static method (change introduced in 3a104d5). We need to instantiate a TTS object.

@jaketae jaketae marked this pull request as ready for review August 15, 2023 00:50
@erogol
Copy link
Member

erogol commented Aug 21, 2023

If you don't mind, this also needs to change in https://github.com/coqui-ai/TTS/blob/dev/docs/source/inference.md

@jaketae
Copy link
Contributor Author

jaketae commented Aug 21, 2023

Hi @erogol, I updated relevant details in inference.md. Let me know if anything seems missing. Thanks!

@erogol erogol merged commit fa0cbd7 into coqui-ai:dev Aug 28, 2023
44 checks passed
@erogol
Copy link
Member

erogol commented Aug 28, 2023

@jaketae thanks!!

@jaketae jaketae deleted the docs-device branch August 28, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants