-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Linux ARM/AARCH wheels for Python 3.7 and 3.9 #2134
Conversation
535459b
to
2d165fd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@reuben could you also retrigger the build here? Will start trying to help today :) |
189097a
to
c529d59
Compare
4dc4259
to
9ac95d3
Compare
@reuben hmmm i think there is just one last job that is failing:
with the following error:
I have tried several things but no dice, wondering if you know what could be the fix for this? |
@wasertech has been working on Python ARM builds in PR #2263, maybe they have some insights? |
9ac95d3
to
91ed4cd
Compare
I think it’s Here : STT/native_client/definitions.mk Line 81 in 2065076
And for aarch64 it should be STT/native_client/definitions.mk Line 101 in 2065076
You can use |
91ed4cd
to
b1093ea
Compare
nice will give it a try, I think we are very close. This build needs to be modulized though :) |
ec0d441
to
a1513ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'm worrying about the duplicated logic between the main yaml file and the multistrap
action. I think you want any logic controlling what we are doing with multistrap in this action and only there.
@lissyx you cool if we address that concern on a follow-up PR? |
Why land something broken to fix it later ? It's not that much work |
7974c2f
to
b617281
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner.👍🏻
but now the test fails 😟
i think you need to install multistrap in the Ubuntu env of the CI 🤔
Like that?
STT/.github/actions/multistrap/action.yml
Line 17 in 0652121
sudo apt-get install -y --no-install-recommends multistrap qemu-user-static |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With all the useless quotes removed :)
aff8fbf
to
7033878
Compare
0cda28d
to
afec01d
Compare
Congrats! 🎉 |
can I be the one 🥲? |
\o/ thanks for driving it through the finish line!! |
No description provided.