Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Linux ARM/AARCH wheels for Python 3.7 and 3.9 #2134

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Conversation

reuben
Copy link
Collaborator

@reuben reuben commented Feb 27, 2022

No description provided.

@wasertech

This comment was marked as outdated.

@mariano-balto
Copy link
Collaborator

@reuben could you also retrigger the build here?
Thanks!

Will start trying to help today :)

@mariano-balto
Copy link
Collaborator

mariano-balto commented Jul 28, 2022

@reuben hmmm i think there is just one last job that is failing:

[LinArmv7|Build Python bindings (3.9, multistrap-raspbian-bullseye, multistrap_raspbian_bullseye.c..]

with the following error:

    func()
  File "/home/runner/work/STT/STT/multistrap-raspbian-bullseye/usr/lib/python3.9/distutils/sysconfig.py", line 472, in _init_posix
    _temp = __import__(name, globals(), locals(), ['build_time_vars'], 0)
ModuleNotFoundError: No module named '_sysconfigdata_m_linux_arm-linux-gnueabihf'
make: *** [Makefile:13: bindings-build] Error 1
make: Leaving directory '/home/runner/work/STT/STT/native_client/python'
Error: Process completed with exit code 2.

I have tried several things but no dice, wondering if you know what could be the fix for this?

@reuben
Copy link
Collaborator Author

reuben commented Jul 28, 2022

@wasertech has been working on Python ARM builds in PR #2263, maybe they have some insights?

@wasertech
Copy link
Collaborator

wasertech commented Jul 29, 2022

I think it’s _sysconfigdata__linux_arm-linux-gnueabihf now?

Here :

PYTHON_SYSCONFIGDATA := _PYTHON_SYSCONFIGDATA_NAME=_sysconfigdata_m_linux_arm-linux-gnueabihf

And for aarch64 it should be _sysconfigdata__linux_aarch64-linux-gnu here

PYTHON_SYSCONFIGDATA := _PYTHON_SYSCONFIGDATA_NAME=_sysconfigdata_m_linux_aarch64-linux-gnu

You can use find /usr/lib/python3.*/ | grep sysconfigdata_ to find it for any platform/distro.

@mariano-balto
Copy link
Collaborator

mariano-balto commented Jul 29, 2022

I think it’s sysconfigdata__linux_arm-linux-gnueabihf now?

Here :

PYTHON_SYSCONFIGDATA := _PYTHON_SYSCONFIGDATA_NAME=_sysconfigdata_m_linux_arm-linux-gnueabihf

And for aarch64 it should be _sysconfigdata__linux_aarch64-linux-gnu here

PYTHON_SYSCONFIGDATA := _PYTHON_SYSCONFIGDATA_NAME=_sysconfigdata_m_linux_aarch64-linux-gnu

nice will give it a try, I think we are very close. This build needs to be modulized though :)

@mariano-balto mariano-balto force-pushed the lin-arm-py-vers branch 8 times, most recently from ec0d441 to a1513ac Compare July 29, 2022 13:19
Copy link
Collaborator

@lissyx lissyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm worrying about the duplicated logic between the main yaml file and the multistrap action. I think you want any logic controlling what we are doing with multistrap in this action and only there.

@mariano-balto
Copy link
Collaborator

mariano-balto commented Aug 4, 2022

LGTM but I'm worrying about the duplicated logic between the main yaml file and the multistrap action. I think you want any logic controlling what we are doing with multistrap in this action and only there.

@lissyx you cool if we address that concern on a follow-up PR?

@lissyx
Copy link
Collaborator

lissyx commented Aug 4, 2022

LGTM but I'm worrying about the duplicated logic between the main yaml file and the multistrap action. I think you want any logic controlling what we are doing with multistrap in this action and only there.

@lissyx you could if we address that concern on a follow-up PR?

Why land something broken to fix it later ? It's not that much work

@mariano-balto mariano-balto force-pushed the lin-arm-py-vers branch 2 times, most recently from 7974c2f to b617281 Compare August 4, 2022 16:07
Copy link
Collaborator

@wasertech wasertech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner.👍🏻
but now the test fails 😟

i think you need to install multistrap in the Ubuntu env of the CI 🤔

Like that?

sudo apt-get install -y --no-install-recommends multistrap qemu-user-static

Copy link
Collaborator

@lissyx lissyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With all the useless quotes removed :)

@mariano-balto mariano-balto force-pushed the lin-arm-py-vers branch 8 times, most recently from aff8fbf to 7033878 Compare August 4, 2022 19:14
@wasertech
Copy link
Collaborator

Congrats! 🎉
I’ll let @reuben do the honors, it’s his branch after all 😉

@mariano-balto
Copy link
Collaborator

Congrats! 🎉 I’ll let @reuben do the honors, it’s his branch after all 😉

can I be the one 🥲?

@reuben reuben merged commit fcc89ab into main Aug 5, 2022
@reuben
Copy link
Collaborator Author

reuben commented Aug 5, 2022

\o/ thanks for driving it through the finish line!!

@mariano-balto mariano-balto deleted the lin-arm-py-vers branch August 7, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants