-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel parsing event #941
Open
rtetley
wants to merge
25
commits into
main
Choose a base branch
from
cancel-event
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cancel parsing event #941
Changes from 20 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
62ab074
feat: make parsing part of the event loop
rtetley d12638f
feat: parse lines individually
rtetley 105352c
feat: cancel parse events when receiving a new one
rtetley df5652d
fix: fix priorities and keep synterp state and only update view once …
rtetley daed67e
cleanup: removed unecessary variables and cancellation handles
rtetley 8634298
feat: create new Observe event
rtetley 6cb17fa
fix: Interrupt execution after validation
rtetley 2029fc8
feat: externalise RangeList type
rtetley eed0df6
cleanup: remove unecessary field in execute event
rtetley da65b44
feat: make the todo queue part ot execution state
rtetley 7a64cb5
feat: add cancellation handles for exec events
rtetley afb495f
feat: new handle event return type for document manager
rtetley c98da57
feat: observe_id is no longer an option
rtetley cbb788d
feat: put all document related events (proofview, errors, move cursor…
rtetley 0a86985
cleanup: remove unecessary events from lsp manager
rtetley dfe8a05
feat: send back notifications returned by the document manager
rtetley 0852fb9
fix: don't forget to move cursor when stepping forward/backward
rtetley 4a349a5
fix: make unit tests compatible with new API
gares 8536071
feat: recompute the overview after a text edit
rtetley 0e8c72d
fix: don't forget to remove events from the todo queue when invalidating
rtetley f4a01c5
fix: adjust the tests to take into account the new validate document …
rtetley b537578
cleanup: remove dead code and inaccurate comments
rtetley a9a743f
cleanup: remove unecessary interpret_in_background API
rtetley 3b1eff8
fix: make the return type of Document.handle_event into a record
rtetley 7cfedb9
fix: stepForward and stepBackward no longer require a position to wor…
rtetley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should build a record for the return type, so that we can name all these documents