-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0] Rename easy_my_coop_api to cooperator_api #230
Conversation
Codecov Report
@@ Coverage Diff @@
## 12.0-rename-easy_my_coop #230 +/- ##
=========================================================
Coverage 60.49% 60.49%
=========================================================
Files 119 119
Lines 4050 4050
Branches 613 613
=========================================================
Hits 2450 2450
Misses 1498 1498
Partials 102 102
Continue to review full report at Codecov.
|
2158cbe
to
6cdb023
Compare
@robinkeunen This has doubtlessly been discussed, but what do we do about stuff like cooperator_api_logs/models/emc_api_log.py? Do we rename it? If we rename it, do we also change the |
Renaming file and model names will be done in a second step, cf battle plan : #204 |
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
074e15b
to
7d03349
Compare
I understand that this needs a code review. Does an analyst also need to verify whether everything still works on the functional side of things? |
@carmenbianca A code review will be enough for that one. We do not use this ourselves (intended to be used with the connector). @enricostano @danypr92 @cesarlr should take a look though. |
Description
Fixes #213
look at this amazing new github pr template. it needs some work
I also grabbed easy_my_coop_api_logs and renamed it to cooperator_api_logs. However, I don't think I understand why this is a separate module, when easy_my_coop explicitly depends on it.
Odoo task (if applicable)
n/a
Checklist before approval