Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] Rename easy_my_coop_api to cooperator_api #230

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

carmenbianca
Copy link
Member

@carmenbianca carmenbianca commented Mar 9, 2022

Description

Fixes #213

look at this amazing new github pr template. it needs some work

I also grabbed easy_my_coop_api_logs and renamed it to cooperator_api_logs. However, I don't think I understand why this is a separate module, when easy_my_coop explicitly depends on it.

Odoo task (if applicable)

n/a

Checklist before approval

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #230 (2158cbe) into 12.0-rename-easy_my_coop (9796f16) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2158cbe differs from pull request most recent head c1c908b. Consider uploading reports for the commit c1c908b to get more accurate results

Impacted file tree graph

@@                    Coverage Diff                    @@
##           12.0-rename-easy_my_coop     #230   +/-   ##
=========================================================
  Coverage                     60.49%   60.49%           
=========================================================
  Files                           119      119           
  Lines                          4050     4050           
  Branches                        613      613           
=========================================================
  Hits                           2450     2450           
  Misses                         1498     1498           
  Partials                        102      102           
Impacted Files Coverage Δ
cooperator_api/controllers/__init__.py 100.00% <ø> (ø)
cooperator_api/controllers/controllers.py 92.30% <ø> (ø)
cooperator_api/models/__init__.py 100.00% <ø> (ø)
cooperator_api/models/auth_api_key.py 81.81% <ø> (ø)
cooperator_api/models/external_id_mixin.py 91.66% <ø> (ø)
cooperator_api/models/subscription_request.py 90.47% <ø> (ø)
cooperator_api/services/__init__.py 100.00% <ø> (ø)
cooperator_api/services/abstract_emc_service.py 100.00% <ø> (ø)
cooperator_api/services/account_invoice_service.py 93.10% <ø> (ø)
cooperator_api/services/account_payment_service.py 76.92% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9796f16...c1c908b. Read the comment docs.

@carmenbianca carmenbianca changed the title [12.0] Rename easy_my_coop_api to cooperators_api [12.0] Rename easy_my_coop_api to cooperator_api Mar 9, 2022
@carmenbianca
Copy link
Member Author

@robinkeunen This has doubtlessly been discussed, but what do we do about stuff like cooperator_api_logs/models/emc_api_log.py? Do we rename it? If we rename it, do we also change the _name variable? Does this need a migration script, or are we fine with keeping stuff as-is as a sort of legacy implementation detail?

@robinkeunen
Copy link
Member

Renaming file and model names will be done in a second step, cf battle plan : #204

@robinkeunen robinkeunen linked an issue Mar 9, 2022 that may be closed by this pull request
1 task
@robinkeunen robinkeunen self-requested a review March 15, 2022 13:44
Base automatically changed from 12.0-rename-easy_my_coop to 12.0-komunigi March 15, 2022 14:08
@carmenbianca
Copy link
Member Author

I understand that this needs a code review. Does an analyst also need to verify whether everything still works on the functional side of things?

@robinkeunen
Copy link
Member

@carmenbianca A code review will be enough for that one. We do not use this ourselves (intended to be used with the connector). @enricostano @danypr92 @cesarlr should take a look though.

@robinkeunen robinkeunen merged commit e1f461a into 12.0-komunigi Mar 18, 2022
@robinkeunen robinkeunen deleted the 12.0-rename-easy_my_coop_api branch March 18, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename easy_my_coop_api to cooperator_api
3 participants