[12.0][IMP] allow different workday lengths #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allow contracts with different workday lengths for different employees of the same company. * use only the resource.calendar of the contracts to define the length of a workday, instead of using the resource.calendar of the company. * improve compatibility with hr_holidays. * test and fix access rights.
huguesdk
force-pushed
the
12.0-imp-allow_different_resource_calendar_day_lengths
branch
from
4ca25c1
to
07aa5f0
Compare
huguesdk
force-pushed
the
12.0-imp-allow_different_resource_calendar_day_lengths
branch
from
07aa5f0
to
d1ddf95
Compare
carmenbianca
requested changes
Sep 2, 2024
Comment on lines
+25
to
+26
| all_attendances = self.attendance_ids | ||
| if not all_attendances: |
There was a problem hiding this comment.
Suggested change
| all_attendances = self.attendance_ids | |
| if not all_attendances: | |
| self.ensure_one() | |
| all_attendances = self.attendance_ids | |
| if not all_attendances: |
There was a problem hiding this comment.
how do you decide whether to call self.ensure_one() or not? because this could be used everywhere.
By splitting this method up, it will be easier for me to do some extension work elsewhere. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
4 tasks
carmenbianca
requested changes
Sep 4, 2024
carmenbianca
requested changes
Sep 9, 2024
huguesdk
force-pushed
the
12.0-imp-allow_different_resource_calendar_day_lengths
branch
2 times, most recently
from
06ecfc4
to
010e92a
Compare
…eger id Signed-off-by: Carmen Bianca BAKKER <[email protected]>
avoid error with contracts without a resource_calendar_id.
huguesdk
force-pushed
the
12.0-imp-allow_different_resource_calendar_day_lengths
branch
from
a6516d0
to
7338dbd
Compare
|
/ocabot merge major |
|
What a great day to merge this nice PR. Let's do it! |
github-grap-bot
deleted the
12.0-imp-allow_different_resource_calendar_day_lengths
branch
|
Congratulations, your PR was merged at cfddd49. Thanks a lot for contributing to coopiteasy. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
odoo task
t12627