Skip to content

Commit

Permalink
Update descriptions re meta and sourceId
Browse files Browse the repository at this point in the history
Update the descriptions of meta and sourceId to show that they SHOULD be filled, stored, and retained if at all possible. Will be required in future major release.
Resolves adewg#366 (sort of)
  • Loading branch information
cookeac committed Nov 16, 2023
1 parent 4b8a90e commit 25c0ce5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion resources/icarResource.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
},
"meta": {

Check failure on line 23 in resources/icarResource.json

View workflow job for this annotation

GitHub Actions / Lint (push)

oas3-schema

Property "$comment" is not expected to be here.

Check failure on line 23 in resources/icarResource.json

View workflow job for this annotation

GitHub Actions / Lint (push)

oas3-schema

Property "$comment" is not expected to be here.

Check failure on line 23 in resources/icarResource.json

View workflow job for this annotation

GitHub Actions / Lint (push)

oas3-schema

Property "$comment" is not expected to be here.

Check failure on line 23 in resources/icarResource.json

View workflow job for this annotation

GitHub Actions / Lint (push)

oas3-schema

Property "$comment" is not expected to be here.

Check failure on line 23 in resources/icarResource.json

View workflow job for this annotation

GitHub Actions / Lint (push)

oas3-schema

Property "$comment" is not expected to be here.
"$ref": "../types/icarMetaDataType.json",
"description": "Meta-data for the resource. Mandatory if you wish to support synchronisation."
"description": "Meta-data for the resource. Mandatory if you wish to support synchronisation.\n Systems should maintain and provide meta data if at all possible.",
"$comment": "ICAR ADE working group intend meta to be required in the next major release of ADE."
},
"location": {
"$ref": "../types/icarLocationIdentifierType.json",
Expand Down
3 changes: 2 additions & 1 deletion types/icarMetaDataType.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
},
"sourceId": {
"type": "string",
"description": "Unique Id (ideally UUID) for the resource in the original source system. Treat source and sourceId as an icarIdentifierType."
"description": "Unique Id within Source (e.g. UUID or composite ID if needed) for the resource in the original source system. \n Systems are expected to populate, store, and return sourceId if at all possible.",
"$comment": "ICAR ADE working group intend to make use of metadata, source and sourceId mandatory in the next major release."

Check failure on line 18 in types/icarMetaDataType.json

View workflow job for this annotation

GitHub Actions / Lint (push)

oas3-schema

Property "$comment" is not expected to be here.
},
"isDeleted": {
"type": "boolean",
Expand Down

0 comments on commit 25c0ce5

Please sign in to comment.