Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update transfers inline with latest spec #398

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Update transfers inline with latest spec #398

merged 2 commits into from
Nov 10, 2023

Conversation

br648
Copy link
Collaborator

@br648 br648 commented Oct 24, 2023

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR seeks to update transfers to be inline with the latest spec which covers additional parameters: https://github.com/google/transit/blob/master/gtfs/spec/en/reference.md#transferstxt

The validation of transfers is to be managed by the MobilityData Validator and as such validation is outside the scope of this PR.

Jira ticket: https://ibisolutions.atlassian.net/jira/software/c/projects/DT/issues/DT-209

binh-dam-ibigroup
binh-dam-ibigroup approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. I'll let the other reviewer decide if more test entries in transfers.txt should be included.

src/main/java/com/conveyal/gtfs/model/Transfer.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/gtfs/model/Transfer.java Show resolved Hide resolved
src/main/java/com/conveyal/gtfs/model/Transfer.java Outdated Show resolved Hide resolved
src/test/resources/fake-agency/transfers.txt Show resolved Hide resolved
@br648 br648 assigned philip-cline and unassigned br648 Oct 27, 2023
philip-cline
philip-cline approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, thanks for the update. I think the tests are fine as is.

@philip-cline philip-cline assigned br648 and unassigned philip-cline Nov 7, 2023
@philip-cline philip-cline merged commit 5212691 into dev Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philip-cline philip-cline philip-cline approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@br648 br648

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@br648 @binh-dam-ibigroup @philip-cline