Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #213

Merged
merged 50 commits into from
Apr 1, 2019
Merged

Release #213

merged 50 commits into from
Apr 1, 2019

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented Apr 1, 2019

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • Code coverage does not significantly worsen (ideally it improves) (remove this if not merging to master)

Description

Release includes the following PRs: #200 #204 #195 #205 #201 #212 #208 #210

evansiroky and others added 30 commits February 11, 2019 16:22
Conflicts:
	src/main/java/com/conveyal/gtfs/loader/JdbcGtfsLoader.java
The GraphQL nested queries up until this change relied on parent tables with foreign refs sharing
the same field name as the primary key on the child table. For example, trips could be joined to a
route on the shared field route_id. This change permits nesting children stops under a parent stop
using stops#parent_station, which will be joined on the parent join value found in stops#stop_id.

refs ibi-group/datatools-ui#428
Create feed registry if not exists when snapshotting
Add codeowners, issue and pr templates
Allow nested queries where field names don't  match
Adds feature to normalize all stop times for a set of pattern stops in order to simplify updating
existing trips in bulk when a pattern changes (e.g., travel times change or new pattern stops are
inserted).
This also fixes a bug where Entity.INT_MISSING was written to the database when arrival/departure
times were missing on a pattern stop.
landonreed and others added 20 commits March 25, 2019 10:02
This fix clarifies a conditional block that was deleting stop_times and frequencies when
calednar#service_id was being modified. These entries will now only be deleted when a pattern is
deleted (the expected behavior).

fixes #203
Refactor field validation in order to store/validate bad values properly
Fix overlapping trips in block check
Conflicts:
	src/test/java/com/conveyal/gtfs/loader/JDBCTableWriterTest.java
Normalize stop times travel times for set of pattern stops
@evansiroky evansiroky assigned landonreed and unassigned evansiroky Apr 1, 2019
@landonreed landonreed merged commit fad8630 into master Apr 1, 2019
@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 4.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@codecov-io
Copy link

codecov-io commented Apr 1, 2019

Codecov Report

Merging #213 into master will decrease coverage by 2.39%.
The diff coverage is 76.51%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #213     +/-   ##
===========================================
- Coverage     62.05%   59.66%   -2.4%     
+ Complexity     1087      893    -194     
===========================================
  Files           147      145      -2     
  Lines          8629     7420   -1209     
  Branches       1160      873    -287     
===========================================
- Hits           5355     4427    -928     
+ Misses         2896     2669    -227     
+ Partials        378      324     -54
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/conveyal/gtfs/error/NewGTFSError.java 75% <ø> (ø) 7 <0> (ø) ⬇️
...in/java/com/conveyal/gtfs/loader/BooleanField.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/com/conveyal/gtfs/loader/DateListField.java 23.07% <0%> (-3.02%) 2 <0> (-2)
...om/conveyal/gtfs/validator/SpeedTripValidator.java 47.61% <0%> (-1.59%) 14 <0> (ø)
...java/com/conveyal/gtfs/loader/StringListField.java 40% <0%> (+3.15%) 3 <0> (-2) ⬇️
...in/java/com/conveyal/gtfs/loader/BatchTracker.java 91.66% <100%> (+1.34%) 7 <0> (-1) ⬇️
...ava/com/conveyal/gtfs/loader/ReferenceTracker.java 100% <100%> (ø) 1 <1> (ø) ⬇️
...ava/com/conveyal/gtfs/loader/IllegalCharacter.java 100% <100%> (ø) 1 <1> (ø) ⬇️
.../com/conveyal/gtfs/loader/JdbcGtfsSnapshotter.java 82.88% <100%> (-5.18%) 27 <1> (-24)
...ain/java/com/conveyal/gtfs/loader/StringField.java 77.77% <100%> (-2.23%) 4 <1> (-3)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eca69fb...b8ed46b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants