Add cluster sync addendum to RFC-0001 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souleb
reviewed
Jun 10, 2024
| - `url`: The URL of the source repository, can be a Git repository HTTP/S or SSH address, an OCI repository address or a Bucket endpoint. | ||
| - `ref`: The source reference, can be a Git ref name e.g. `refs/heads/main`, an OCI tag e.g. `latest` or a Bucket name. | ||
| - `path`: The path to the source directory containing the kustomize overlay or plain Kubernetes manifests to sync from. | ||
| - `pullSecret`: The name of the Kubernetes secret that contains the credentials to pull the source repository. This field is optional. |
There was a problem hiding this comment.
whjat about the provider field? It's true that we cannot do it for git yet, but we can already have it in the rfc.
There was a problem hiding this comment.
Provider is set from the cluster.type field, no point in duplicating it here.
| - `kind`: The source kind, supported values are `GitRepository`, `OCIRepository` and `Bucket`. | ||
| - `url`: The URL of the source repository, can be a Git repository HTTP/S or SSH address, an OCI repository address or a Bucket endpoint. | ||
| - `ref`: The source reference, can be a Git ref name e.g. `refs/heads/main`, an OCI tag e.g. `latest` or a Bucket name. | ||
| - `path`: The path to the source directory containing the kustomize overlay or plain Kubernetes manifests to sync from. |
There was a problem hiding this comment.
I have written a question about it in the implementation PR, but what about LayerSelector? I would rather use that than path for an oci Artifact.
There was a problem hiding this comment.
LayerSelector could be added via a kustomize patch if anyone needs it, for now there is no practical use to it. The artifacts in this case are create with flux push artifact for the fleet Git repo content, so path is a must for any of this to work.
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
rfc-0001-cluster-sync
branch
from
c2901ab to
6649114
Compare
Signed-off-by: Stefan Prodan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the RFC so that the
FluxInstanceresource can be configured to instruct the operator to generate a Flux source (GitRepository,OCIRepositoryorBucket) and a FluxKustomizationto sync the cluster state with the source repository.Reference implementation: controlplaneio-fluxcd/flux-operator#20