Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move validations to value types #113

Merged
merged 1 commit into from
Nov 25, 2023
Merged

refactor: move validations to value types #113

merged 1 commit into from
Nov 25, 2023

Conversation

injeniero
Copy link
Contributor

Move validation of Value types to their generated Struct instead of validating in the containing Struct.

Ticket

#111

How Has This Been Verified?

I run all the test suite. I also tested with the project we are working.

Checklist:

  • The change works as expected.
  • New code can be debugged via logs.
  • I have added tests to cover my changes.
  • I have locally run the tests and all new and existing tests passed.
  • Requires updates to the documentation.
  • I have made the required changes to the documents.

@injeniero injeniero requested a review from a team as a code owner November 23, 2023 21:05
@injeniero injeniero requested review from LucasRoesler and removed request for a team November 23, 2023 21:05
@injeniero
refactor: move validations to value types
330b040 
Also fix date and date-time validation
@injeniero injeniero changed the title move validations to value types refactor: move validations to value types Nov 23, 2023
@injeniero
Copy link
Contributor Author

@LucasRoesler this is what I was able to do. I wont feel bad if you decide to drop it all to the 🗑️

LucasRoesler
LucasRoesler approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@LucasRoesler LucasRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty reasonable to me :shipit:

@LucasRoesler LucasRoesler merged commit ae80075 into contiamo:master Nov 25, 2023
2 of 3 checks passed
@injeniero injeniero deleted the fix/value-type-validation branch November 27, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasRoesler LucasRoesler LucasRoesler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@injeniero @LucasRoesler