Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to development back-merge #285

Merged
merged 5 commits into from
Jul 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ FLAGS
-n, --name=<value> Name of the app to be created
--app-type=<option> [default: stack] Type of app
<options: stack|organization>
--boilerplate=<value> Provide a boilerplate from the following options: App Boilerplate, DAM App Boilerplate or
Ecommerce App Boilerplate
--boilerplate=<value> Provide a boilerplate. <options: App Boilerplate|DAM App Boilerplate|Ecommerce App Boilerplate>

DESCRIPTION
Create a new app in Developer Hub and optionally clone a boilerplate locally.
Expand Down
2 changes: 1 addition & 1 deletion src/commands/app/create.ts
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export default class Create extends BaseCommand<typeof Create> {
// Get the directory inside the zip file
const zipEntries = zip.getEntries();
const firstEntry = zipEntries[0];
const sourcePath = resolve(dataDir, firstEntry.entryName.split("/")[0]);
const sourcePath = resolve(sanitizePath(dataDir), sanitizePath(firstEntry.entryName.split("/")[0]));

if (this.flags["data-dir"] && !existsSync(this.flags["data-dir"])) {
mkdirSync(this.flags["data-dir"], { recursive: true });
Expand Down
3 changes: 2 additions & 1 deletion src/messages/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ const appCreate = {
REGISTER_THE_APP_ON_DEVELOPER_HUB:
"Registering the app with the name {appName} on the Developer Hub...",
START_APP_COMMAND: "Start the app using the following command: {command}",
BOILERPLATE_TEMPLATES: "Provide a boilerplate from the following options: App Boilerplate, DAM App Boilerplate or Ecommerce App Boilerplate"
BOILERPLATE_TEMPLATES: "Provide a boilerplate. <options: App Boilerplate|DAM App Boilerplate|Ecommerce App Boilerplate>",
SELECT_BOILERPLATE: "Select one from the following boilerplates:"
};

const getAppMsg = {
Expand Down
2 changes: 1 addition & 1 deletion src/util/inquirer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ const selectedBoilerplate = async (): Promise<any> => {
type: "search-list",
name: "App",
choices: boilerplates.map((bp) => bp.name),
message: appCreate.BOILERPLATE_TEMPLATES,
message: appCreate.SELECT_BOILERPLATE,
})
.then((name) => {
return find(boilerplates, (boilerplate) => boilerplate.name === name);
Expand Down
Loading