Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Docs to Rich Text App Release [INTEG-2321] #4040

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

sarahlessner
Copy link
Contributor

Purpose

Approach

Testing steps

Breaking Changes

Dependencies and/or References

Deployment

@sarahlessner sarahlessner requested a review from a team as a code owner January 8, 2025 18:44
@sarahlessner sarahlessner changed the title Feat: New app - Docs to Rich Text [INTEG-2321] feat: Docs to Rich Text App Release [INTEG-2321] Jan 8, 2025
Comment on lines 27 to 28
"deploy": "contentful-app-scripts upload --ci --bundle-dir ./out --organization-id ${DEFINITIONS_ORG_ID} --definition-id 4tDyevo7sMwvZhDGKzFHVw --token ${CONTENTFUL_CMA_TOKEN}",
"deploy:staging": "contentful-app-scripts upload --ci --bundle-dir ./build --organization-id ${TEST_ORG_ID} --definition-id 6J4rXeXJ0DWrePRwZyULO8 --token ${TEST_CMA_TOKEN}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deploy goes to /out and deploy:staging goes to /build, I assume one of these is wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good catch probably a copy/paste error I made I'll fix

Copy link
Contributor

@mgoudy91 mgoudy91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build folder question, otherwise looks good!

@sarahlessner sarahlessner requested a review from mgoudy91 January 8, 2025 20:30
@sarahlessner sarahlessner added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 02f9da8 Jan 8, 2025
8 of 9 checks passed
@sarahlessner sarahlessner deleted the feat/docs-to-rich-text-new-app-INTEG-2321 branch January 8, 2025 20:38
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants