fix(gql): inifite loop with circular references [] #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrishelgert
commented
Oct 26, 2023
•
chrishelgert
commented
- Use the depth limit for GraphQL if no gqlParams have been provided, to prevent an endless loop of updates for circular references
- Drop VisitedReferencesMap and EntityReferenceMap in favor of the EditorEntityStore
- Move the store up on a higher level to be better accessible and increase update speed
- Move the depth handling the other way around, instead of increase the depth, decrease the remaining depth
- Additionally define a custom depth for rich text (only two levels instead of max 10)
chrishelgert
force-pushed
the
fix/gql-infinite-loop
branch
from
cdf90d1 to
a7ec530
Compare
chrishelgert
force-pushed
the
fix/gql-infinite-loop
branch
from
a7ec530 to
8e3daba
Compare
chrishelgert
force-pushed
the
fix/gql-infinite-loop
branch
2 times, most recently
from
c6fe18f to
f766be8
Compare
aodhagan-cf
reviewed
Oct 27, 2023
| return maxDepth >= 0; | ||
| } | ||
|
|
||
| function getRichTextDepth(maxDepth: number) { |
There was a problem hiding this comment.
return Math.min(maxDepth - 1, MAX_RTE_DEPTH); does this do the same?
chrishelgert
force-pushed
the
fix/gql-infinite-loop
branch
from
f766be8 to
a73451d
Compare
aodhagan-cf
reviewed
Oct 27, 2023
| depth: number, | ||
| visitedReferenceMap: Map<string, Reference>, | ||
| sendMessage: SendMessage | ||
| maxDepth: number, |
There was a problem hiding this comment.
why have you changed this from depth to maxDepth sorry I think I'm missing this
There was a problem hiding this comment.
So we can define a different maxDepth for RichText
it's easier in this one, as we otherwise would need to start with 8 for rich text and check for the limit of 10
| @@ -9,6 +9,7 @@ export const TOOLTIP_HEIGHT = 32; | |||
| export const TOOLTIP_PADDING_LEFT = 5; | |||
|
|
|||
| export const MAX_DEPTH = 10; | |||
| export const MAX_RTE_DEPTH = 2; | |||
There was a problem hiding this comment.
Can you explain why we need 2 for rich text?
There was a problem hiding this comment.
1 Level depth for the direct references
Assuming it's an entry it could be relevant to resolve also the asset of this entry, therefore then 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.