Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): don’t focus menu if menu has just been removed #2968

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

veu
Copy link
Contributor

@veu veu commented Jan 7, 2025

Purpose of PR

Fix edge case where a menu is opened and removed from the DOM at the same time before we can focus it in the next tick.

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 3be4b76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@contentful/f36-menu Patch
@contentful/f36-accordion Patch
@contentful/f36-asset Patch
@contentful/f36-autocomplete Patch
@contentful/f36-badge Patch
@contentful/f36-button Patch
@contentful/f36-card Patch
@contentful/f36-collapse Patch
@contentful/f36-copybutton Patch
@contentful/f36-core Patch
@contentful/f36-datetime Patch
@contentful/f36-datepicker Patch
@contentful/f36-drag-handle Patch
@contentful/f36-entity-list Patch
@contentful/f36-empty-state Patch
@contentful/f36-forms Patch
@contentful/f36-icon Patch
@contentful/f36-header Patch
@contentful/f36-list Patch
@contentful/f36-modal Patch
@contentful/f36-navbar Patch
@contentful/f36-note Patch
@contentful/f36-notification Patch
@contentful/f36-pagination Patch
@contentful/f36-pill Patch
@contentful/f36-popover Patch
@contentful/f36-skeleton Patch
@contentful/f36-spinner Patch
@contentful/f36-table Patch
@contentful/f36-tabs Patch
@contentful/f36-text-link Patch
@contentful/f36-tooltip Patch
@contentful/f36-typography Patch
@contentful/f36-components Patch
@contentful/f36-image Patch
@contentful/f36-avatar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jan 7, 2025 9:06am

Copy link

github-actions bot commented Jan 7, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 112.11 KB (-0.08% 🔽) 2.3 s (-0.08% 🔽) 1.4 s (+2.2% 🔺) 3.6 s
Module 110.87 KB (+0.06% 🔺) 2.3 s (+0.06% 🔺) 1.6 s (-5.92% 🔽) 3.9 s

@veu veu marked this pull request as ready for review January 7, 2025 09:23
@veu veu requested review from damann and a team as code owners January 7, 2025 09:23
Copy link
Collaborator

@Lelith Lelith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@veu veu merged commit 2d4097b into main Jan 7, 2025
17 checks passed
@veu veu deleted the F36-1606-fix branch January 7, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants