Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ModalHeader): enable dynamic aria-label value #2961

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cf-remylenoir
Copy link
Collaborator

@cf-remylenoir cf-remylenoir commented Dec 16, 2024

Purpose of PR

We want to prevent hardcoded strings so that our components are fully dynamic.

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@cf-remylenoir cf-remylenoir self-assigned this Dec 16, 2024
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Dec 17, 2024 10:42am

Copy link

changeset-bot bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: 73d03fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cf-remylenoir cf-remylenoir marked this pull request as ready for review December 16, 2024 14:01
@cf-remylenoir cf-remylenoir requested review from damann and a team as code owners December 16, 2024 14:01
Copy link

github-actions bot commented Dec 16, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 112.2 KB (-0.01% 🔽) 2.3 s (-0.01% 🔽) 1.5 s (+16.57% 🔺) 3.7 s
Module 110.97 KB (+0.09% 🔺) 2.3 s (+0.09% 🔺) 1.7 s (0%) 3.9 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant