Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strip env variables from CDN build #2919

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

andipaetzold
Copy link
Contributor

@andipaetzold andipaetzold commented Oct 23, 2024

The CDN build currently inlines environment variables. This could be a security issue. This PR ensures that no environment variables (and therefore secrets) are inlined into the binary.

The issue was detected by the netlify secret scanner.

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: 3846895

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Oct 23, 2024 3:09pm

@andipaetzold andipaetzold self-assigned this Oct 23, 2024
@andipaetzold andipaetzold marked this pull request as ready for review October 23, 2024 15:04
@andipaetzold andipaetzold requested review from damann and a team as code owners October 23, 2024 15:04
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 112.03 KB (0%) 2.3 s (0%) 1.6 s (+4.54% 🔺) 3.8 s
Module 110.84 KB (0%) 2.3 s (0%) 1.6 s (-3.18% 🔽) 3.8 s

@andipaetzold andipaetzold merged commit 453e7f9 into main Oct 23, 2024
12 checks passed
@andipaetzold andipaetzold deleted the CFISO-1735-cdn-env branch October 23, 2024 15:13
@andipaetzold andipaetzold changed the title fix: stripe env variables from CDN build fix: strip env variables from CDN build Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants