-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autocomplete): add separate test ID prop for suggestion box popover #2602
Conversation
🦋 Changeset detectedLatest commit: 7bd494c The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
49712cc
to
d56031e
Compare
d56031e
to
3f21eef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
@veu just pls don't forget to add a chengelog otherwise the change won't be published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an additional
popoverTestId
prop to theAutocomplete
component. When passed it replaces the default suggestion box popover test ID (cf-autocomplete-container
).Purpose of PR
Make elements inside the portal used for the suggestion box identifiable for tests.
PR Checklist
readme.md
file(s)