Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autocomplete): add separate test ID prop for suggestion box popover #2602

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

veu
Copy link
Contributor

@veu veu commented Oct 30, 2023

Add an additional popoverTestId prop to the Autocomplete component. When passed it replaces the default suggestion box popover test ID (cf-autocomplete-container).

Purpose of PR

Make elements inside the portal used for the suggestion box identifiable for tests.

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023

🦋 Changeset detected

Latest commit: 7bd494c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@contentful/f36-autocomplete Minor
@contentful/f36-accordion Minor
@contentful/f36-asset Minor
@contentful/f36-badge Minor
@contentful/f36-button Minor
@contentful/f36-card Minor
@contentful/f36-collapse Minor
@contentful/f36-copybutton Minor
@contentful/f36-core Minor
@contentful/f36-datetime Minor
@contentful/f36-datepicker Minor
@contentful/f36-drag-handle Minor
@contentful/f36-entity-list Minor
@contentful/f36-empty-state Minor
@contentful/f36-forms Minor
@contentful/f36-icon Minor
@contentful/f36-list Minor
@contentful/f36-menu Minor
@contentful/f36-modal Minor
@contentful/f36-note Minor
@contentful/f36-notification Minor
@contentful/f36-pagination Minor
@contentful/f36-pill Minor
@contentful/f36-popover Minor
@contentful/f36-skeleton Minor
@contentful/f36-spinner Minor
@contentful/f36-table Minor
@contentful/f36-tabs Minor
@contentful/f36-text-link Minor
@contentful/f36-tooltip Minor
@contentful/f36-typography Minor
@contentful/f36-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Nov 1, 2023 8:41am

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 129.58 KB (+0.01% 🔺) 2.6 s (+0.01% 🔺) 517 ms (+106.27% 🔺) 3.2 s
Module 126.05 KB (+0.01% 🔺) 2.6 s (+0.01% 🔺) 280 ms (-38.48% 🔽) 2.9 s

@veu veu force-pushed the autocomplete-popover-test-ids branch from d56031e to 3f21eef Compare October 31, 2023 09:12
@veu veu changed the title feat(autocomplete): pass down test ID to popover elements feat(autocomplete): add separate test ID prop for suggestion box popover Oct 31, 2023
@veu veu marked this pull request as ready for review October 31, 2023 09:25
@veu veu requested review from Lelith, cf-remylenoir, damann and a team as code owners October 31, 2023 09:25
@veu veu requested review from andipaetzold and giotiskl October 31, 2023 09:25
Copy link
Contributor

@bgutsol bgutsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
@veu just pls don't forget to add a chengelog otherwise the change won't be published.

Copy link
Collaborator

@Lelith Lelith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@veu veu merged commit 763c182 into main Nov 1, 2023
3 checks passed
@veu veu deleted the autocomplete-popover-test-ids branch November 1, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants