Remove unused CONTENTFUL_HOST environment variable #9344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also it was set without using cross-env, causing problems for Windows users.
👷 Deploy request for ecommerce-app-base-components pending review.Visit the deploys page to approve it
|
Seth-Carter
requested changes
Dec 17, 2024
…ve-external-references-clean-up-for-windows-users
…of github.com:twogood/contentful-apps into native-external-references-clean-up-for-windows-users
PR updated based on feedback. Commit history got weird though. |
|
Hi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Solve problem for Windows user that posted in Contentful Discord:
https://discord.com/channels/1030176999471321129/1317987388567457835
Approach
Use
cross-envso that the scripts works on Windows too.Note:
CONTENTFUL_HOSTis read by thehostvariable in http.ts but then thehostvariable is not actually used in http.ts.Testing steps
Run affected scripts at command line.
Breaking Changes
No.
Dependencies and/or References
No.
Deployment
No, this is example code.