chore: Remove Typeform vulnerable dependencies [EXT-5806] #8954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecommerce-app-base-components canceled.
|
sarahlessner
force-pushed
the
chore/typeform-remove-react-scripts-emotion-forma36-EXT-5806
branch
from
add698a to
4ac717e
Compare
mgoudy91
force-pushed
the
chore/typeform-remove-react-scripts-emotion-forma36-EXT-5806
branch
from
765947e to
b338107
Compare
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
mgoudy91
reviewed
Sep 25, 2024
| import { BASE_URL, CLIENT_ID } from '../constants'; | ||
|
|
||
| interface Props { | ||
| sdk?: AppExtensionSDK; | ||
| expireSoon?: boolean; | ||
| isFullWidth: boolean; | ||
| buttonType?: 'primary' | 'positive' | 'negative' | 'muted' | 'naked' | undefined; | ||
| buttonType?: 'primary' | 'positive' | 'negative' | 'secondary' | 'transparent' | undefined; |
mgoudy91
reviewed
Sep 25, 2024
| @@ -2,6 +2,6 @@ const SDK_WINDOW_HEIGHT = 450; | |||
| const BASE_URL = 'https://api.typeform.com'; | |||
|
|
|||
| // TODO Move to env var | |||
| const CLIENT_ID = 'HC3UDnoiaP1UCMqJ7kCAyTFdHrDt8nLtXx4BKRJxom2M'; | |||
| const CLIENT_ID = '2vyzzT2AjqrtfWKmaigvZjF8oYwUXrJABmcS5WK4MPJg'; | |||
There was a problem hiding this comment.
Thanks actually I should move that back. There's some weird stuff in the instructions where this client ID is pointed to the prodcution app. but why is it just hardcoded like this in the first place? haha there's a TODO around moving stuff to env variables which seems like we should do that eventually but didn't yet. I'd also like to test this one better on staging before merging so let's chat about that later too.
There was a problem hiding this comment.
changed that back and ready for rereview @mgoudy91
mgoudy91
approved these changes
Sep 25, 2024
…-5806' of github.com:contentful/apps into chore/typeform-remove-react-scripts-emotion-forma36-EXT-5806
…n-forma36-EXT-5806
…n-forma36-EXT-5806
mgoudy91
approved these changes
Sep 25, 2024
sarahlessner
deleted the
chore/typeform-remove-react-scripts-emotion-forma36-EXT-5806
branch
david-shibley-contentful
pushed a commit
that referenced
this pull request
Sep 25, 2024
* replace react scripts with vite * updates jest with vi in tests * updates emotion * wip forma changes * wip forma changes * tests passing * update config * remove console logs * remove console logs * replace react scripts with vite * updates jest with vi in tests * updates emotion * wip forma changes * wip forma changes * tests passing * update config * remove console logs * remove console logs * undo change to constants * undo change to constants
sarahlessner
added a commit
that referenced
this pull request
Sep 26, 2024
)" This reverts commit 8e106fd.
sarahlessner
restored the
chore/typeform-remove-react-scripts-emotion-forma36-EXT-5806
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replaces react-scripts with vite, remove emotion old library, remove old forma libraries