Allow specifying user shell at toolbox creation #445

yann-soubeyrand · 2020-05-15T19:32:27Z

When creating a toolbox the user shell can be specified and this shell will be
used when entering the toolbox.

Signed-off-by: Yann Soubeyrand [email protected]

Closes #413

softwarefactory-project-zuul · 2020-05-15T19:36:05Z

Build failed.

shellcheck : SUCCESS in 1m 13s
test-with-podman-stable-f30 : FAILURE in 2m 49s
test-with-podman-stable-f31 : FAILURE in 2m 28s
test-with-podman-rawhide : FAILURE in 2m 42s

src/cmd/run.go

yann-soubeyrand · 2020-05-15T19:46:08Z

Build failed.

* [shellcheck ](https://softwarefactory-project.io/zuul/t/local/build/15af452961464632940b3d9affe9a94d) : SUCCESS in 1m 13s

* [test-with-podman-stable-f30 ](https://softwarefactory-project.io/zuul/t/local/build/fbb58d02449848c7abb0b2a3f2af221d) : FAILURE in 2m 49s

* [test-with-podman-stable-f31 ](https://softwarefactory-project.io/zuul/t/local/build/c00aefea732d42d8a8a5f0ee78a8fada) : FAILURE in 2m 28s

* [test-with-podman-rawhide ](https://softwarefactory-project.io/zuul/t/local/build/d3f373a87e984eac93021e0be87472b7) : FAILURE in 2m 42s

Is it some kind of normal error or did I break something? It seems that meson cannot find the go compiler.

yann-soubeyrand · 2020-05-22T11:09:16Z

Hi,
@HarryMichal, @debarshiray, could you have a look at this PR and tell me if I should rework it please?

softwarefactory-project-zuul · 2020-07-04T15:09:55Z

Build failed.

shellcheck : NODE_FAILURE in 0s
test-with-podman-stable-f30 : FAILURE in 2m 32s
test-with-podman-stable-f31 : NODE_FAILURE in 0s
test-with-podman-rawhide : FAILURE in 3m 24s

softwarefactory-project-zuul · 2020-07-14T19:46:44Z

Build failed.

shellcheck : SUCCESS in 3m 08s
test-with-podman-stable-f31 : FAILURE in 2m 31s
test-with-podman-rawhide : FAILURE in 3m 59s

HarryMichal · 2020-07-15T09:54:57Z

@yann-soubeyrand, thank you for the patch! I'm currently focusing on v0.1.0 that does not add any new features. When we get that out, I'll review this in-depth.

softwarefactory-project-zuul · 2020-10-28T09:48:31Z

Build failed.

shellcheck : SUCCESS in 2m 45s
system-test-fedora-31 : SUCCESS in 3m 55s
system-test-fedora-32 : SUCCESS in 3m 13s
system-test-fedora-33 : FAILURE in 3m 48s
system-test-fedora-rawhide : SUCCESS in 6m 08s

debarshiray · 2020-12-18T17:18:34Z

What's the use-case for this?

Toolbox containers are so-called pet containers, and meant to be somewhat long-lived interactive command-line environments. Hence, I'd expect users to configure their default shell in the usual way.

yann-soubeyrand · 2020-12-31T13:21:58Z

Hello @debarshiray,

Indeed, I configure my default shell (zsh) in my toolbox container. However, I keep the system default shell on the host (bash on Fedora Silverblue). This is for several reasons: I try to avoid installing extra packages on my Silverblue host, and having a different shell on the host and inside my toolbox allows me to quickly differentiate a host shell and a toolbox shell.

As I understood, you validated the idea (#413 (comment)), that's why I've worked on it ;-)

debarshiray · 2021-01-05T00:15:11Z

However, I keep the system default shell on the host (bash on
Fedora Silverblue). This is for several reasons: I try to avoid
installing extra packages on my Silverblue host, and having a
different shell on the host and inside my toolbox allows me to
quickly differentiate a host shell and a toolbox shell.

Indeed. Not having to install extra packages on a Silverblue host is a very good reason.

As I understood, you validated the idea (#413 (comment)), that's why I've worked on it ;-)

Oops, my mistake. I was quickly going through the open PRs and forgot about the earlier issue. Sorry about that.

yann-soubeyrand · 2021-01-07T16:34:58Z

As I understood, you validated the idea (#413 (comment)), that's why I've worked on it ;-)

Oops, my mistake. I was quickly going through the open PRs and forgot about the earlier issue. Sorry about that.

No problem ;-)

I've just rebased my PR so that it applies cleanly.

softwarefactory-project-zuul · 2021-01-07T16:36:10Z

Build succeeded.

shellcheck : SUCCESS in 2m 10s
system-test-fedora-31 : SUCCESS in 3m 46s
system-test-fedora-32 : SUCCESS in 3m 12s
system-test-fedora-33 : SUCCESS in 3m 17s
system-test-fedora-rawhide : SUCCESS in 5m 46s

yann-soubeyrand · 2021-04-26T18:43:50Z

Hello @HarryMichal @debarshiray, is there something blocking this PR which I can act on?

softwarefactory-project-zuul · 2021-05-04T21:14:19Z

Build succeeded.

unit-test : SUCCESS in 2m 47s
system-test-fedora-32 : SUCCESS in 5m 44s
system-test-fedora-33 : SUCCESS in 5m 35s
system-test-fedora-34 : SUCCESS in 5m 47s
system-test-fedora-rawhide : SUCCESS in 12m 16s

When creating a toolbox the user shell can be specified and this shell will be used when entering the toolbox. Signed-off-by: Yann Soubeyrand <[email protected]>

softwarefactory-project-zuul · 2021-07-30T13:57:49Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

debarshiray · 2021-11-16T01:58:20Z

I suppose this needs to rebased after #813

debarshiray

Sorry for the delay!

src/cmd/create.go

src/cmd/run.go

debarshiray · 2021-11-16T02:10:58Z

I am going to close this pull request because it would need a complete re-write. See my comments above.

However, we still want the feature, so please feel free to submit a new pull request.

debarshiray · 2022-11-28T19:43:53Z

I am going to close this pull request because it would need a complete re-write. See my comments above.

However, we still want the feature, so please feel free to submit a new pull request.

@yann-soubeyrand has a work in progress at #1037

yann-soubeyrand changed the title ~~Allow specifying user shell at toolbox creation (#413)~~ Allow specifying user shell at toolbox creation May 15, 2020

yann-soubeyrand changed the title ~~Allow specifying user shell at toolbox creation~~ Allow specifying user shell at toolbox creation (Closes #413) May 15, 2020

yann-soubeyrand changed the title ~~Allow specifying user shell at toolbox creation (Closes #413)~~ Allow specifying user shell at toolbox creation May 15, 2020

yann-soubeyrand commented May 15, 2020

View reviewed changes

src/cmd/run.go Show resolved Hide resolved

yann-soubeyrand commented May 15, 2020

View reviewed changes

src/cmd/run.go Show resolved Hide resolved

yann-soubeyrand force-pushed the master branch from 21d82db to 6c34586 Compare July 4, 2020 15:04

yann-soubeyrand force-pushed the master branch from 6c34586 to 6bb4ecd Compare July 14, 2020 19:41

HarryMichal added 3. Enhancement Improvement to an existing feature 6. Major Change May cause breakage labels Jul 15, 2020

HarryMichal added this to the Release 0.2.0 milestone Jul 15, 2020

HarryMichal modified the milestones: Release 0.2.0, Release 0.1.0 Sep 9, 2020

yann-soubeyrand force-pushed the master branch from 6bb4ecd to 4b21f5d Compare October 28, 2020 09:41

yann-soubeyrand force-pushed the master branch from 4b21f5d to 9b520a0 Compare January 7, 2021 16:29

HarryMichal modified the milestones: Release 0.1.0, Release 0.2.0 Mar 1, 2021

Base automatically changed from master to main March 25, 2021 22:25

yann-soubeyrand force-pushed the master branch from 9b520a0 to 5a8fc29 Compare May 4, 2021 21:00

Allow specifying user shell at toolbox creation

ee1450c

When creating a toolbox the user shell can be specified and this shell will be used when entering the toolbox. Signed-off-by: Yann Soubeyrand <[email protected]>

yann-soubeyrand force-pushed the master branch from 5a8fc29 to ee1450c Compare July 30, 2021 13:57

debarshiray requested changes Nov 16, 2021

View reviewed changes

src/cmd/create.go Show resolved Hide resolved

src/cmd/run.go Show resolved Hide resolved

debarshiray closed this Nov 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow specifying user shell at toolbox creation #445

Allow specifying user shell at toolbox creation #445

yann-soubeyrand commented May 15, 2020 •

edited

Loading

softwarefactory-project-zuul bot commented May 15, 2020

yann-soubeyrand commented May 15, 2020

yann-soubeyrand commented May 22, 2020

softwarefactory-project-zuul bot commented Jul 4, 2020

softwarefactory-project-zuul bot commented Jul 14, 2020

HarryMichal commented Jul 15, 2020

softwarefactory-project-zuul bot commented Oct 28, 2020

debarshiray commented Dec 18, 2020

yann-soubeyrand commented Dec 31, 2020

debarshiray commented Jan 5, 2021

yann-soubeyrand commented Jan 7, 2021

softwarefactory-project-zuul bot commented Jan 7, 2021

yann-soubeyrand commented Apr 26, 2021

softwarefactory-project-zuul bot commented May 4, 2021

softwarefactory-project-zuul bot commented Jul 30, 2021

debarshiray commented Nov 16, 2021

debarshiray left a comment

debarshiray commented Nov 16, 2021

debarshiray commented Nov 28, 2022

Allow specifying user shell at toolbox creation #445

Allow specifying user shell at toolbox creation #445

Conversation

yann-soubeyrand commented May 15, 2020 • edited Loading

softwarefactory-project-zuul bot commented May 15, 2020

yann-soubeyrand commented May 15, 2020

yann-soubeyrand commented May 22, 2020

softwarefactory-project-zuul bot commented Jul 4, 2020

softwarefactory-project-zuul bot commented Jul 14, 2020

HarryMichal commented Jul 15, 2020

softwarefactory-project-zuul bot commented Oct 28, 2020

debarshiray commented Dec 18, 2020

yann-soubeyrand commented Dec 31, 2020

debarshiray commented Jan 5, 2021

yann-soubeyrand commented Jan 7, 2021

softwarefactory-project-zuul bot commented Jan 7, 2021

yann-soubeyrand commented Apr 26, 2021

softwarefactory-project-zuul bot commented May 4, 2021

softwarefactory-project-zuul bot commented Jul 30, 2021

debarshiray commented Nov 16, 2021

debarshiray left a comment

Choose a reason for hiding this comment

debarshiray commented Nov 16, 2021

debarshiray commented Nov 28, 2022

yann-soubeyrand commented May 15, 2020 •

edited

Loading