-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #1564 usr home #1582
base: main
Are you sure you want to change the base?
fixes #1564 usr home #1582
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ import ( | |
"errors" | ||
"fmt" | ||
"os" | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nitpick: stray newline. |
||
|
||
"github.com/containers/toolbox/pkg/utils" | ||
"github.com/spf13/cobra" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,6 @@ import ( | |
"fmt" | ||
"io/ioutil" | ||
"os" | ||
"os/user" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I bet this line is causing: cmd/initContainer.go:270:21: undefined: user
cmd/initContainer.go:580:15: undefined: user Why did you remove the import of |
||
"path/filepath" | ||
"strconv" | ||
"strings" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ import ( | |
"errors" | ||
"fmt" | ||
"os" | ||
"os/user" | ||
"strings" | ||
|
||
"github.com/containers/toolbox/pkg/utils" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,7 @@ import ( | |
"fmt" | ||
"io" | ||
"os" | ||
"os/user" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I bet this line is causing: cmd/utils.go:30:2: user redeclared in this block
cmd/utils.go:28:2: other declaration of user The code was already importing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now you removed both imports, and it's causing: cmd/utils.go:333:38: undefined: user |
||
"os/exec" | ||
"os/user" | ||
"path/filepath" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be
homeDir
, notHomeDir
. This is causing: