Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: Run the CI on Ubuntu 22.04 #1319

Merged

Conversation

debarshiray
Copy link
Member

@debarshiray debarshiray commented Jun 22, 2023

Now that Toolbx offers built-in support for Ubuntu containers [1],
adding an Ubuntu host to the upstream CI will help ensure that Toolbx
continues to work well on Ubuntu. Ubuntu 22.04 is the latest long term
support (or LTS) release [2] from Ubuntu, and is the latest Ubuntu
version that GitHub provides runners for [3].

Ubuntu 22.04 only has Bats 1.2.1 [4], while Toolbx requires 1.7.0 [5];
and Shadow 4.8 [6], while Toolbx requires 4.9 because it needs
libsubid.so [7,8]. Hence, newer versions of these dependencies need to
be built to run the tests. The build flags for Shadow were taken from
the Debian package [9].

A separate sub-directory inside $GITHUB_WORKSPACE [10] is used for
Toolbx itself to prevent codespell from getting triggered by spelling
mistakes in these dependencies themselves [11].

Unfortunately, the SHELL environment variable goes mysteriously missing
from the runtime environment of the GitHub Actions workflow [12]. This
breaks the 'create' and 'enter' commands, and therefore tests involving
them can't be run until this is resolved. Meanwhile, running the CI on
Ubuntu with a subset of the tests, is still better than not running the
CI on Ubuntu at all.

[1] Commit a84a358
#483
#1284

[2] https://wiki.ubuntu.com/Releases

[3] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

[4] https://packages.ubuntu.com/jammy/bats

[5] Commit e22a82f
#1273

[6] https://packages.ubuntu.com/source/jammy/shadow
https://packages.ubuntu.com/source/jammy-updates/shadow

[7] Shadow commit 0a7888b1fad613a0
shadow-maint/shadow@0a7888b1fad613a0
shadow-maint/shadow#154

[8] Commit ca8007c
#1074

[9] https://salsa.debian.org/debian/shadow/

[10] https://docs.github.com/en/actions/learn-github-actions/variables

[11] bats-core/bats-core#743

[12] https://github.com/orgs/community/discussions/59413

@debarshiray debarshiray requested a review from HarryMichal as a code owner June 22, 2023 17:23
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch 2 times, most recently from 2e79c9e to 2fe65b7 Compare June 22, 2023 17:33
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/26ad23135bf6456e9672d64d4e7c349a

✔️ unit-test SUCCESS in 9m 11s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 09s
✔️ unit-test-restricted SUCCESS in 8m 50s
✔️ system-test-fedora-rawhide SUCCESS in 22m 18s
✔️ system-test-fedora-38 SUCCESS in 20m 56s
✔️ system-test-fedora-37 SUCCESS in 19m 56s

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 22, 2023
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from 692ef19 to 7e284c4 Compare June 22, 2023 19:55
@debarshiray debarshiray changed the title .github/workflows: Run unit tests on Ubuntu 22.04 .github/workflows: Run the tests on Ubuntu 22.04 Jun 22, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/767e230c79ea48c0a6d620124a59bc54

✔️ unit-test SUCCESS in 9m 37s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 2m 59s
✔️ unit-test-restricted SUCCESS in 8m 36s
✔️ system-test-fedora-rawhide SUCCESS in 22m 05s
✔️ system-test-fedora-38 SUCCESS in 21m 13s
✔️ system-test-fedora-37 SUCCESS in 21m 14s

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 22, 2023
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from 7e284c4 to 9540d96 Compare June 22, 2023 20:37
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 22, 2023
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from 9540d96 to 4e73e95 Compare June 22, 2023 20:42
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 22, 2023
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from 4e73e95 to 6a590a2 Compare June 22, 2023 20:55
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 22, 2023
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from 6a590a2 to 29b09bc Compare June 22, 2023 21:00
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 22, 2023
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from 29b09bc to bf02c94 Compare June 22, 2023 21:04
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 22, 2023
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from bf02c94 to 2ea9815 Compare June 22, 2023 21:10
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 22, 2023
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from 2ea9815 to 0a085d9 Compare June 22, 2023 21:15
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 22, 2023
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from 0a085d9 to b26c6ab Compare June 22, 2023 21:21
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 22, 2023
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from b26c6ab to f40beab Compare June 22, 2023 21:28
@debarshiray debarshiray marked this pull request as draft June 22, 2023 21:30
@debarshiray debarshiray changed the title .github/workflows: Run the tests on Ubuntu 22.04 [WIP] .github/workflows: Run the tests on Ubuntu 22.04 Jun 22, 2023
@debarshiray
Copy link
Member Author

/cc @Jmennius

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/e789a3004ba844a7a57b35b02aa4408a

✔️ unit-test SUCCESS in 9m 27s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 06s
✔️ unit-test-restricted SUCCESS in 8m 27s
✔️ system-test-fedora-rawhide SUCCESS in 22m 58s
✔️ system-test-fedora-38 SUCCESS in 21m 52s
✔️ system-test-fedora-37 SUCCESS in 21m 51s

@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from fdafc80 to baa6910 Compare June 23, 2023 10:13
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/01cadfe97ee54f4391708e23f6d0c4d9

✔️ unit-test SUCCESS in 9m 40s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 36s
✔️ unit-test-restricted SUCCESS in 8m 26s
✔️ system-test-fedora-rawhide SUCCESS in 22m 45s
✔️ system-test-fedora-38 SUCCESS in 22m 23s
✔️ system-test-fedora-37 SUCCESS in 21m 42s

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 23, 2023
Now that Toolbx offers built-in support for Ubuntu containers [1],
adding an Ubuntu host to the upstream CI will help ensure that Toolbx
continues to work well on Ubuntu.  Ubuntu 22.04 is the latest long term
support (or LTS) release [2] from Ubuntu, and GitHub provides runners
for GitHub workflows [3].

Ubuntu 22.04 only has Bats 1.2.1 [4], while Toolbx requires 1.7.0 [5];
and Shadow 4.8 [6], while libsubid.so was introduced in Shadow 4.9 [7].
Hence, newer versions of these dependencies need to be built to run the
tests.

Note that a separate sub-directory inside $GITHUB_WORKSPACE [8] is used
for Toolbx itself to prevent codespell from getting triggered by
problems in the dependencies themselves [9].

[1] Commit a84a358
    containers#483
    containers#1284

[2] https://wiki.ubuntu.com/Releases

[3] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

[4] https://packages.ubuntu.com/jammy/bats

[5] Commit e22a82f
    containers#1273

[6] https://packages.ubuntu.com/source/jammy/shadow
    https://packages.ubuntu.com/source/jammy-updates/shadow

[7] Shadow commit 0a7888b1fad613a0
    shadow-maint/shadow@0a7888b1fad613a0
    shadow-maint/shadow#154

[8] https://docs.github.com/en/actions/learn-github-actions/variables

[9] bats-core/bats-core#743

containers#1319
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from 2af5863 to ac3d700 Compare June 23, 2023 11:56
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 23, 2023
Now that Toolbx offers built-in support for Ubuntu containers [1],
adding an Ubuntu host to the upstream CI will help ensure that Toolbx
continues to work well on Ubuntu.  Ubuntu 22.04 is the latest long term
support (or LTS) release [2] from Ubuntu, and GitHub provides runners
for GitHub workflows [3].

Ubuntu 22.04 only has Bats 1.2.1 [4], while Toolbx requires 1.7.0 [5];
and Shadow 4.8 [6], while libsubid.so was introduced in Shadow 4.9 [7].
Hence, newer versions of these dependencies need to be built to run the
tests.

Note that a separate sub-directory inside $GITHUB_WORKSPACE [8] is used
for Toolbx itself to prevent codespell from getting triggered by
problems in the dependencies themselves [9].

[1] Commit a84a358
    containers#483
    containers#1284

[2] https://wiki.ubuntu.com/Releases

[3] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

[4] https://packages.ubuntu.com/jammy/bats

[5] Commit e22a82f
    containers#1273

[6] https://packages.ubuntu.com/source/jammy/shadow
    https://packages.ubuntu.com/source/jammy-updates/shadow

[7] Shadow commit 0a7888b1fad613a0
    shadow-maint/shadow@0a7888b1fad613a0
    shadow-maint/shadow#154

[8] https://docs.github.com/en/actions/learn-github-actions/variables

[9] bats-core/bats-core#743

containers#1319
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch 3 times, most recently from e6f2143 to 0b24bfa Compare June 23, 2023 12:21
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/690f2931f265485998e27b6bb649c8a3

✔️ unit-test SUCCESS in 12m 18s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 18s
✔️ unit-test-restricted SUCCESS in 9m 01s
✔️ system-test-fedora-rawhide SUCCESS in 22m 15s
✔️ system-test-fedora-38 SUCCESS in 24m 30s
✔️ system-test-fedora-37 SUCCESS in 24m 44s

@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch 8 times, most recently from 927e2ea to 7acd364 Compare June 26, 2023 16:27
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/a147095807ba4551848dbc583d6f7432

✔️ unit-test SUCCESS in 9m 23s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 2m 55s
✔️ unit-test-restricted SUCCESS in 8m 30s
✔️ system-test-fedora-rawhide SUCCESS in 22m 06s
✔️ system-test-fedora-38 SUCCESS in 21m 26s
✔️ system-test-fedora-37 SUCCESS in 20m 31s

@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from 7acd364 to a75962e Compare June 26, 2023 19:47
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/7989800797ef4f2fb91b3493fdb08099

✔️ unit-test SUCCESS in 9m 08s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 00s
✔️ unit-test-restricted SUCCESS in 8m 52s
✔️ system-test-fedora-rawhide SUCCESS in 22m 37s
✔️ system-test-fedora-38 SUCCESS in 21m 17s
✔️ system-test-fedora-37 SUCCESS in 21m 07s

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jun 27, 2023
Now that Toolbx offers built-in support for Ubuntu containers [1],
adding an Ubuntu host to the upstream CI will help ensure that Toolbx
continues to work well on Ubuntu.  Ubuntu 22.04 is the latest long term
support (or LTS) release [2] from Ubuntu, and GitHub provides runners
for GitHub workflows [3].

Ubuntu 22.04 only has Bats 1.2.1 [4], while Toolbx requires 1.7.0 [5];
and Shadow 4.8 [6], while libsubid.so was introduced in Shadow 4.9 [7].
Hence, newer versions of these dependencies need to be built to run the
tests.

Note that a separate sub-directory inside $GITHUB_WORKSPACE [8] is used
for Toolbx itself to prevent codespell from getting triggered by
problems in the dependencies themselves [9].

[1] Commit a84a358
    containers#483
    containers#1284

[2] https://wiki.ubuntu.com/Releases

[3] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

[4] https://packages.ubuntu.com/jammy/bats

[5] Commit e22a82f
    containers#1273

[6] https://packages.ubuntu.com/source/jammy/shadow
    https://packages.ubuntu.com/source/jammy-updates/shadow

[7] Shadow commit 0a7888b1fad613a0
    shadow-maint/shadow@0a7888b1fad613a0
    shadow-maint/shadow#154

[8] https://docs.github.com/en/actions/learn-github-actions/variables

[9] bats-core/bats-core#743

containers#1319
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from a75962e to d52a9df Compare June 27, 2023 10:03
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/d623bf80dfe24d50989c45937ad2862b

✔️ unit-test SUCCESS in 9m 17s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 56s
✔️ unit-test-restricted SUCCESS in 8m 28s
✔️ system-test-fedora-rawhide SUCCESS in 22m 36s
✔️ system-test-fedora-38 SUCCESS in 20m 15s
✔️ system-test-fedora-37 SUCCESS in 20m 51s

Now that Toolbx offers built-in support for Ubuntu containers [1],
adding an Ubuntu host to the upstream CI will help ensure that Toolbx
continues to work well on Ubuntu.  Ubuntu 22.04 is the latest long term
support (or LTS) release [2] from Ubuntu, and is the latest Ubuntu
version that GitHub provides runners for [3].

Ubuntu 22.04 only has Bats 1.2.1 [4], while Toolbx requires 1.7.0 [5];
and Shadow 4.8 [6], while Toolbx requires 4.9 because it needs
libsubid.so [7,8].  Hence, newer versions of these dependencies need to
be built to run the tests.  The build flags for Shadow were taken from
the Debian package [9].

A separate sub-directory inside $GITHUB_WORKSPACE [10] is used for
Toolbx itself to prevent codespell from getting triggered by spelling
mistakes in these dependencies themselves [11].

Unfortunately, the SHELL environment variable goes mysteriously missing
from the runtime environment of the GitHub Actions workflow [12].  This
breaks the 'create' and 'enter' commands, and therefore tests involving
them can't be run until this is resolved.  Meanwhile, running the CI on
Ubuntu with a subset of the tests, is still better than not running the
CI on Ubuntu at all.

[1] Commit a84a358
    containers#483
    containers#1284

[2] https://wiki.ubuntu.com/Releases

[3] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

[4] https://packages.ubuntu.com/jammy/bats

[5] Commit e22a82f
    containers#1273

[6] https://packages.ubuntu.com/source/jammy/shadow
    https://packages.ubuntu.com/source/jammy-updates/shadow

[7] Shadow commit 0a7888b1fad613a0
    shadow-maint/shadow@0a7888b1fad613a0
    shadow-maint/shadow#154

[8] Commit ca8007c
    containers#1074

[9] https://salsa.debian.org/debian/shadow/

[10] https://docs.github.com/en/actions/learn-github-actions/variables

[11] bats-core/bats-core#743

[12] https://github.com/orgs/community/discussions/59413

containers#1319
@debarshiray debarshiray force-pushed the wip/rishi/run-tests-on-ubuntu-22.04 branch from d52a9df to 8c28dc2 Compare June 27, 2023 11:11
@debarshiray debarshiray changed the title [WIP] .github/workflows: Run the tests on Ubuntu 22.04 .github/workflows: Run the CI on Ubuntu 22.04 Jun 27, 2023
@debarshiray debarshiray marked this pull request as ready for review June 27, 2023 11:13
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/fd34f3b4ffbe447c976e42682bf8b64f

✔️ unit-test SUCCESS in 9m 27s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 20s
✔️ unit-test-restricted SUCCESS in 8m 32s
✔️ system-test-fedora-rawhide SUCCESS in 22m 15s
✔️ system-test-fedora-38 SUCCESS in 21m 09s
✔️ system-test-fedora-37 SUCCESS in 20m 39s

@debarshiray debarshiray merged commit 8c28dc2 into containers:main Jun 27, 2023
@debarshiray debarshiray deleted the wip/rishi/run-tests-on-ubuntu-22.04 branch June 27, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant