Feature request: specify shell at toolbox creation time

[yann-soubeyrand]

Hello,

Currently, the shell launched when entering a toolbox is the one specified in the SHELL environment variable. I'd like to be able to specify which shell will be used by a toolbox at creation time. This would allow having a different shell on the host (bash) and in the toolbox (zsh). It would also allow having several toolboxes, each with its specific shell (maybe a python toolbox using an interactive python interpreter as shell?).

I can try to work on a PR if this idea is accepted.

[HarryMichal]

Hey @yann-soubeyrand! Sounds good to me. Let's hear what @debarshiray thinks.

If you were to make the PR, would you mind making it for the new version of Toolbox?

[debarshiray]

Yes, this does sound like a neat idea to me.

And, yes, as @HarryMichal said, please work on the Go version.

[debarshiray]

#908 has some more in-depth discussion on this.

[debarshiray]

Duplicate of #908

[debarshiray]

I realized that I never said this clearly ...

It will be better to teach Toolbx to respect the user's local configuration inside the container instead of adding an option to toolbox create to specify a shell. eg., a user can use chsh(1) or usermod -s inside the container to change their shell.

The biggest problem with adding an option to toolbox create is that it won't have any effect on existing containers. Plus, every extra option increases Toolbx's the maintenance burden -- it's another user-visible thing that can't be changed without consequences.

This is what #908 is about.