Skip to content

Commit

Permalink
.github/workflows: Run the tests on Ubuntu 22.04
Browse files Browse the repository at this point in the history
Now that Toolbx offers built-in support for Ubuntu containers [1], it
makes sense to test that it works well on Ubuntu hosts.  Ubuntu 22.04 is
the latest long term support (or LTS) release [2] from Ubuntu, and
GitHub provides runners for GitHub workflows [3].

Ubuntu 22.04 only has Bats 1.2.1 [4], while Toolbx requires 1.7.0 [5];
and Shadow 4.8 [6], while libsubid.so was introduced in Shadow 4.9 [7].
Hence, newer versions of these dependencies need to be built to run the
tests.

Note that a separate sub-directory inside $GITHUB_WORKSPACE [8] is used
for Toolbx itself to prevent codespell from getting triggered by
problems in the dependencies themselves [9].

[1] Commit a84a358
    #483
    #1284

[2] https://wiki.ubuntu.com/Releases

[3] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

[4] https://packages.ubuntu.com/jammy/bats

[5] Commit e22a82f
    #1273

[6] https://packages.ubuntu.com/source/jammy/shadow
    https://packages.ubuntu.com/source/jammy-updates/shadow

[7] Shadow commit 0a7888b1fad613a0
    shadow-maint/shadow@0a7888b1fad613a0
    shadow-maint/shadow#154

[8] https://docs.github.com/en/actions/learn-github-actions/variables

[9] bats-core/bats-core#743

#1319
  • Loading branch information
debarshiray committed Jun 23, 2023
1 parent b57dfd8 commit 33d0adf
Show file tree
Hide file tree
Showing 2 changed files with 147 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
/.github/workflows/arch-images.yaml @Foxboron
/.github/workflows/arch-images-pr.yaml @Foxboron
/.github/workflows/ubuntu-images.yaml @Jmennius
/.github/workflows/ubuntu-tests.yaml @Jmennius
/data/gfx/*.gif @jimmac
/images/arch @Foxboron
/images/rhel @debarshiray @olivergs
Expand Down
146 changes: 146 additions & 0 deletions .github/workflows/ubuntu-tests.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,146 @@
#
# Copyright © 2023 Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

name: ubuntu-tests

on:
pull_request:
branches:
- main
schedule:
- cron: '0 0 * * *'

jobs:
ubuntu-jammy-tests:
runs-on: ubuntu-22.04

steps:
- name: Checkout
uses: actions/checkout@v3
with:
path: containers/toolbox
submodules: true

- name: Install deb packages
run: |
sudo apt-get update
sudo apt-get install \
apache2-utils \
bash-completion \
codespell \
fish \
gcc \
go-md2man \
golang \
meson \
ninja-build \
openssl \
podman \
shellcheck \
skopeo \
systemd \
udisks2
- name: Checkout Bats
uses: actions/checkout@v3
with:
path: bats-core/bats-core
ref: v1.9.0
repository: bats-core/bats-core.git
submodules: true

- name: Install deb packages for Bats
run: |
sudo apt-get update
sudo apt-get install \
bash \
parallel
- name: Install Bats
run: sudo ./install.sh /usr/local
working-directory: bats-core/bats-core

- name: Checkout shadow
uses: actions/checkout@v3
with:
path: shadow-maint/shadow
ref: 4.13
repository: shadow-maint/shadow.git
submodules: true

- name: Install deb packages for shadow
run: |
sudo apt-get update
sudo apt-get install \
autoconf \
autopoint \
gettext \
libaudit-dev \
libcrypt-dev \
libpam0g-dev \
libselinux1-dev \
libsemanage-dev
- name: Set up build directory for shadow
run: |
autoreconf --force --install --verbose
./configure \
--disable-account-tools-setuid \
--disable-silent-rules \
--with-audit \
--with-libpam \
--with-selinux \
--with-yescrypt \
--without-acl \
--without-attr \
--without-su \
--without-tcb \
SHELL=/bin/sh
working-directory: shadow-maint/shadow

- name: Build shadow
run: make
working-directory: shadow-maint/shadow

- name: Install shadow
run: sudo make install
working-directory: shadow-maint/shadow

- name: Download Go modules
run: go mod download -x
working-directory: containers/toolbox/src

- name: Set up build directory
run: meson setup --fatal-meson-warnings builddir
working-directory: containers/toolbox

- name: Build
run: meson compile -C builddir --verbose
working-directory: containers/toolbox

- name: Install
run: sudo meson install -C builddir
working-directory: containers/toolbox

- name: Unit tests
run: meson test -C builddir --verbose
working-directory: containers/toolbox

- name: System tests
run: bats --timing test/system
env:
TOOLBOX: /usr/local/bin/toolbox
working-directory: containers/toolbox

0 comments on commit 33d0adf

Please sign in to comment.