Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Add various debug logging #2439

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Contributor

To aid debugging ostreedev/ostree-rs-ext#657

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Feel free to merge as is EDIT if this is sufficient.

cmd/skopeo/proxy.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -782,6 +784,8 @@ func (h *proxyHandler) processRequest(readBytes []byte) (rb replyBuf, terminate
err = fmt.Errorf("invalid request: %v", err)
return
}
logrus.Debugf("Executing method %s", req.Method)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(For very broken or adversarial values, %q throughout would be better, but that’s not really relevant here.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah...I guess I need to just internalize "use %q by default" in general.

@mtrmac
Copy link
Contributor

mtrmac commented Oct 11, 2024

@cgwalters please try rebasing on top of main; that will include an updated golangci-lint, and there’s a chance that might affect the osx test timing out. At least, we would be working off a shared baseline.

@cgwalters
Copy link
Contributor Author

Ugh...sorry, when trying to clean this up I messed up and pushed to actual main, not my branch. I'm going to change the permissions on this repo so that not even repo admins can force push - if anyone objects let me know, we can change it later.

@cgwalters cgwalters closed this Oct 12, 2024
auto-merge was automatically disabled October 12, 2024 12:34

Pull request was closed

cgwalters added a commit to cgwalters/containers-image-proxy-rs that referenced this pull request Oct 18, 2024
To aid debugging ostreedev/ostree-rs-ext#657

This will be especially handy with containers/skopeo#2439

Signed-off-by: Colin Walters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants