-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy: Add various debug logging #2439
Conversation
Ephemeral COPR build failed. @containers/packit-build please check. |
ae0122c
to
8db0d51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
Feel free to merge as is EDIT if this is sufficient.
To aid debugging ostreedev/ostree-rs-ext#657 Signed-off-by: Colin Walters <[email protected]>
8db0d51
to
e715317
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -782,6 +784,8 @@ func (h *proxyHandler) processRequest(readBytes []byte) (rb replyBuf, terminate | |||
err = fmt.Errorf("invalid request: %v", err) | |||
return | |||
} | |||
logrus.Debugf("Executing method %s", req.Method) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(For very broken or adversarial values, %q
throughout would be better, but that’s not really relevant here.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah...I guess I need to just internalize "use %q by default" in general.
@cgwalters please try rebasing on top of |
Ugh...sorry, when trying to clean this up I messed up and pushed to actual main, not my branch. I'm going to change the permissions on this repo so that not even repo admins can force push - if anyone objects let me know, we can change it later. |
Pull request was closed
To aid debugging ostreedev/ostree-rs-ext#657 This will be especially handy with containers/skopeo#2439 Signed-off-by: Colin Walters <[email protected]>
To aid debugging ostreedev/ostree-rs-ext#657