Quadlet - make sure the /etc/containers/systemd/users is traversed in rootless #24815
Cirrus CI / Validate source code changes
failed
Dec 10, 2024 in 4m 34s
Task Summary
Instruction main failed in 04:17
Details
✅ 00:12 clone
✅ 00:01 setup
❌ 04:17 main
hack/golangci-lint.sh run
Running golangci-lint for ABI
Build Tags ABI: apparmor,seccomp,selinux,systemd
Skipped directories ABI:
+ ./bin/golangci-lint run --timeout=10m --build-tags=apparmor,seccomp,selinux,systemd --exclude-dirs=
Running golangci-lint for TUNNEL
Build Tags TUNNEL: apparmor,seccomp,selinux,remote
Skipped directories TUNNEL:
+ ./bin/golangci-lint run --timeout=10m --build-tags=apparmor,seccomp,selinux,remote --exclude-dirs=
/usr/bin/pre-commit run -a
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.git.
[INFO] Initializing environment for https://github.com/codespell-project/codespell.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/codespell-project/codespell.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
Mixed line ending........................................................Passed
check BOM - deprecated: use fix-byte-order-marker........................Passed
Check that executables have shebangs.....................................Passed
Check for merge conflicts................................................Passed
Check Yaml...............................................................Passed
codespell................................................................Passed
make -C test/tools build/git-validation
make[1]: Entering directory '/var/tmp/go/src/github.com/containers/podman/test/tools'
go build -o build/git-validation ./vendor/github.com/vbatts/git-validation
make[1]: Leaving directory '/var/tmp/go/src/github.com/containers/podman/test/tools'
Validating vs commit '07dddebd1209ec1cabc35613d970fc821618fd2c'
GIT_CHECK_EXCLUDE="./vendor:./test/tools/vendor:docs/make.bat:test/buildah-bud/buildah-tests.diff:test/e2e/quadlet/remap-keep-id2.container" ./test/tools/build/git-validation -run short-subject -range 07dddebd1209ec1cabc35613d970fc821618fd2c..HEAD
time="2024-12-10T14:40:17-06:00" level=info msg="using commit range: 07dddebd1209ec1cabc35613d970fc821618fd2c..HEAD"
* 4c238aad6 "Quadlet - make sure the /etc/containers/systemd/users is traversed in rootless" ... PASS
hack/swagger-check
contrib/cirrus/pr-removes-fixed-skips
+ make tests-included # /var/tmp/go/src/github.com/containers/podman/./contrib/cirrus/runner.sh:32 in _run_validate-source()
contrib/cirrus/pr-should-include-tests
pr-should-include-tests: PR does not include changes in the 'tests' directory
Please write a regression test for what you're fixing. Even if it
seems trivial or obvious, try to add a test that will prevent
regressions.
If your change is minor, feel free to piggyback on already-written
tests, possibly just adding a small step to a similar existing test.
Every second counts in CI.
If your commit really, truly does not need tests, you can proceed
by asking a repo maintainer to set the 'No New Tests' github label.
This will only be done when there's no reasonable alternative.
make: *** [Makefile:779: tests-included] Error 1
Exit status: 2
Loading