Add support for bridge mode #24677
Merged
Add support for bridge mode #24677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Zimmermann <[email protected]>
|
@Luap99 PTAL |
baude
reviewed
Nov 25, 2024
| @@ -118,6 +126,9 @@ Additionally the `bridge` driver supports the following options: | |||
| - `com.docker.network.bridge.name`: This option assigns the given name to the created Linux Bridge | |||
| - `com.docker.network.driver.mtu`: Sets the Maximum Transmission Unit (MTU) and takes an integer value. | |||
| - `vrf`: This option assigns a VRF to the bridge interface. It accepts the name of the VRF and defaults to none. Can only be used with the Netavark network backend. | |||
| - `mode`: This option sets the specified bridge mode on the interface. Defaults to `managed`. Supported values: | |||
| - `managed`: Podman creates and deleted the bridge. It will also setup sysctls and firewall rules for it. | |||
|
/approve |
openshift-ci
bot
added
the
approved
|
Docs changes LGTM |
Luap99
reviewed
Nov 26, 2024
| @@ -118,6 +126,9 @@ Additionally the `bridge` driver supports the following options: | |||
| - `com.docker.network.bridge.name`: This option assigns the given name to the created Linux Bridge | |||
| - `com.docker.network.driver.mtu`: Sets the Maximum Transmission Unit (MTU) and takes an integer value. | |||
| - `vrf`: This option assigns a VRF to the bridge interface. It accepts the name of the VRF and defaults to none. Can only be used with the Netavark network backend. | |||
| - `mode`: This option sets the specified bridge mode on the interface. Defaults to `managed`. Supported values: | |||
| - `managed`: Podman creates and deleted the bridge. It will also setup sysctls and firewall rules for it. | |||
There was a problem hiding this comment.
Maybe add that the firewall rules are added to MASQUERADE/NAT the traffic and for port forwarding DNAT rules are added. And then in the unmanaged case make clear no firewall rules are added which means no DNAT rules for port forwarding as well which might surprise users if they add ports but they don't work.
Signed-off-by: Michael Zimmermann <[email protected]>
This goes into more detail about what this option actually does. Signed-off-by: Michael Zimmermann <[email protected]>
M1cha
force-pushed
the
network-create-docs
branch
from
162bf15 to
e608874
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, Luap99, M1cha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Cockpit tests failed for commit e608874. @martinpitt, @jelly, @mvollmer please check. |
openshift-merge-bot
bot
merged commit 0cfe47b
into
containers:main
85 of 86 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply updates
common, as there is nothing to do from the podman side. I added documentation for this new option and improved the--internaldocumentation.Related:
modeoption for bridge common#2247Does this PR introduce a user-facing change?